Bug 1333990: Follow-up: Return before wrapping result value on error. draft
authorKris Maglione <maglione.k@gmail.com>
Fri, 17 Mar 2017 14:34:55 -0700
changeset 500886 94055b352dc120229cada5f68409664c275b164b
parent 500885 45e0fda3c15fc4fdc30c93d3d858819c640a2fc3
child 549738 5bac1fa81404bc329f16e237e39aeac5c8d7263a
push id49830
push usermaglione.k@gmail.com
push dateFri, 17 Mar 2017 21:53:14 +0000
bugs1333990
milestone55.0a1
Bug 1333990: Follow-up: Return before wrapping result value on error. MozReview-Commit-ID: AwGVr3gjzd0
js/xpconnect/loader/ChromeScriptLoader.cpp
--- a/js/xpconnect/loader/ChromeScriptLoader.cpp
+++ b/js/xpconnect/loader/ChromeScriptLoader.cpp
@@ -306,16 +306,17 @@ PrecompiledScript::ExecuteInGlobal(JSCon
 {
     {
         RootedObject targetObj(aCx, JS_FindCompilationScope(aCx, aGlobal));
         JSAutoCompartment ac(aCx, targetObj);
 
         Rooted<JSScript*> script(aCx, mScript);
         if (!JS::CloneAndExecuteScript(aCx, script, aRval)) {
             aRv.NoteJSContextException(aCx);
+            return;
         }
     }
 
     JS_WrapValue(aCx, aRval);
 }
 
 void
 PrecompiledScript::GetUrl(nsAString& aUrl)