Bug 1347238 - Add a check for rootNode in getAllGrids. r=jdescottes draft
authorGabriel Luong <gabriel.luong@gmail.com>
Fri, 17 Mar 2017 14:27:40 +0100
changeset 500708 14ddca06fb7aee341c09b480fa0c4821be6f77cc
parent 500707 a13dc6642789e1ced2fa069f52fe685099099ea2
child 549679 1819164d1d409e186238f79f1a81781d142e6876
push id49767
push userbmo:gl@mozilla.com
push dateFri, 17 Mar 2017 13:28:25 +0000
reviewersjdescottes
bugs1347238
milestone55.0a1
Bug 1347238 - Add a check for rootNode in getAllGrids. r=jdescottes MozReview-Commit-ID: 7MzFuiW2Ju0
devtools/server/actors/layout.js
--- a/devtools/server/actors/layout.js
+++ b/devtools/server/actors/layout.js
@@ -120,21 +120,26 @@ var LayoutActor = ActorClassWithSpec(lay
    * iterating below the given rootNode and optionally including nested frames.
    *
    * @param  {NodeActor} rootNode
    * @param  {Boolean} traverseFrames
    *         Whether or not we should iterate through nested frames.
    * @return {Array} An array of GridActor objects.
    */
   getAllGrids: function (rootNode, traverseFrames) {
+    let grids = [];
+
+    if (!rootNode) {
+      return grids;
+    }
+
     if (!traverseFrames) {
       return this.getGrids(rootNode.rawNode);
     }
 
-    let grids = [];
     for (let {document} of this.tabActor.windows) {
       grids = [...grids, ...this.getGrids(document.documentElement)];
     }
 
     return grids;
   },
 
   onNavigate: function () {