Bug 1222032 - Improve copy for disambiguating login update draft
authorJim Porter <jporter@mozilla.com>
Thu, 16 Mar 2017 19:14:38 -0500
changeset 500306 ddf04a943b9c067ba35b94a347b11d69973ad307
parent 500240 39607304b774591fa6e32c4b06158d869483c312
child 549598 8dc41842fc98a78e4bb0dacad34a55427dd2a34b
push id49679
push userbmo:squibblyflabbetydoo@gmail.com
push dateFri, 17 Mar 2017 01:06:41 +0000
bugs1222032
milestone55.0a1
Bug 1222032 - Improve copy for disambiguating login update MozReview-Commit-ID: Ga3pybr1yGY
mobile/android/components/LoginManagerPrompter.js
mobile/locales/en-US/overrides/passwordmgr.properties
toolkit/components/passwordmgr/nsLoginManagerPrompter.js
toolkit/locales/en-US/chrome/passwordmgr/passwordmgr.properties
--- a/mobile/android/components/LoginManagerPrompter.js
+++ b/mobile/android/components/LoginManagerPrompter.js
@@ -289,17 +289,17 @@ LoginManagerPrompter.prototype = {
    *       from the login selected by the user.
    * 
    * Note; XPCOM stupidity: |count| is just |logins.length|.
    */
   promptToChangePasswordWithUsernames : function (logins, count, aNewLogin) {
     const buttonFlags = Ci.nsIPrompt.STD_YES_NO_BUTTONS;
 
     var usernames = logins.map(l => l.username);
-    var dialogText  = this._getLocalizedString("userSelectText");
+    var dialogText  = this._getLocalizedString("userSelectText2");
     var dialogTitle = this._getLocalizedString("passwordChangeTitle");
     var selectedIndex = { value: null };
 
     // If user selects ok, outparam.value is set to the index
     // of the selected username.
     var ok = this._promptService.select(null,
       dialogTitle, dialogText,
       usernames.length, usernames,
--- a/mobile/locales/en-US/overrides/passwordmgr.properties
+++ b/mobile/locales/en-US/overrides/passwordmgr.properties
@@ -8,15 +8,15 @@ rememberButton=Remember
 neverButton=Never
 
 # String is the login's hostname
 updatePassword=Update saved password for %S?
 updatePasswordNoUser=Update saved password for this login?
 updateButton=Update
 dontUpdateButton=Don't update
 
-userSelectText=Please confirm which user you are changing the password for
+userSelectText2=Select which login to update:
 passwordChangeTitle=Confirm Password Change
 
 # Strings used by PromptService.js
 rememberPassword=Use Password Manager to remember this password.
 username=Username
 password=Password
--- a/toolkit/components/passwordmgr/nsLoginManagerPrompter.js
+++ b/toolkit/components/passwordmgr/nsLoginManagerPrompter.js
@@ -1360,17 +1360,17 @@ LoginManagerPrompter.prototype = {
    *       from the login selected by the user.
    *
    * Note; XPCOM stupidity: |count| is just |logins.length|.
    */
   promptToChangePasswordWithUsernames(logins, count, aNewLogin) {
     this.log("promptToChangePasswordWithUsernames with count:", count);
 
     var usernames = logins.map(l => l.username);
-    var dialogText  = this._getLocalizedString("userSelectText");
+    var dialogText  = this._getLocalizedString("userSelectText2");
     var dialogTitle = this._getLocalizedString("passwordChangeTitle");
     var selectedIndex = { value: null };
 
     // If user selects ok, outparam.value is set to the index
     // of the selected username.
     var ok = this._promptService.select(this._chromeWindow,
                             dialogTitle, dialogText,
                             usernames.length, usernames,
--- a/toolkit/locales/en-US/chrome/passwordmgr/passwordmgr.properties
+++ b/toolkit/locales/en-US/chrome/passwordmgr/passwordmgr.properties
@@ -44,17 +44,17 @@ passwordChangeTitle = Confirm Password C
 # LOCALIZATION NOTE (updatePasswordMsg):
 # String is the username for the login.
 updatePasswordMsg = Would you like to update the saved password for “%S”?
 updatePasswordMsgNoUser = Would you like to update the saved password?
 notifyBarUpdateButtonText = Update Password
 notifyBarUpdateButtonAccessKey = U
 notifyBarDontChangeButtonText = Don’t Change
 notifyBarDontChangeButtonAccessKey = D
-userSelectText = Please confirm which user you are changing the password for
+userSelectText2 = Select which login to update:
 hidePasswords=Hide Passwords
 hidePasswordsAccessKey=P
 showPasswords=Show Passwords
 showPasswordsAccessKey=P
 noMasterPasswordPrompt=Are you sure you wish to show your passwords?
 removeAllPasswordsPrompt=Are you sure you wish to remove all passwords?
 removeAllPasswordsTitle=Remove all passwords
 removeLoginPrompt=Are you sure you wish to remove this login?