Bug 1344604 - part2: Return empty DocumentFragment if the ConvertCueToDOMTree() return null. r=alwu
It is a regression of bug1307710, if something wrong during the ConvertCueToDOMTree() in vtt.jsm, we will get null ptr.
MozReview-Commit-ID: LSQrJIhBzRU
--- a/dom/media/TextTrackCue.cpp
+++ b/dom/media/TextTrackCue.cpp
@@ -131,16 +131,19 @@ TextTrackCue::GetCueAsHTML()
nsPIDOMWindowInner* window = mDocument->GetInnerWindow();
if (!window) {
return mDocument->CreateDocumentFragment();
}
nsCOMPtr<nsIDOMDocumentFragment> frag;
sParserWrapper->ConvertCueToDOMTree(window, this,
getter_AddRefs(frag));
+ if (!frag) {
+ return mDocument->CreateDocumentFragment();
+ }
return frag.forget().downcast<DocumentFragment>();
}
void
TextTrackCue::SetTrackElement(HTMLTrackElement* aTrackElement)
{
mTrackElement = aTrackElement;
}