Bug 1346236 - Fixed incorrect learn more link on MOZILLA_PKIX_ERROR_KEY_PINNING_FAILURE in aboutNetError.xhtml. r?johannh draft
authormeghana <meghanagupta3@gmail.com>
Wed, 15 Mar 2017 23:14:20 +0530
changeset 499369 939879ec28e0b0dc9f66059196918e7004ec4bd6
parent 499337 8c89d1991786625a64d868798281610872a2bc26
child 549325 0df731ab260a006a8d12f89602a2fd4f514ce948
push id49382
push userbmo:meghanagupta3@gmail.com
push dateWed, 15 Mar 2017 17:45:17 +0000
reviewersjohannh
bugs1346236
milestone55.0a1
Bug 1346236 - Fixed incorrect learn more link on MOZILLA_PKIX_ERROR_KEY_PINNING_FAILURE in aboutNetError.xhtml. r?johannh MozReview-Commit-ID: EUNk0wdI6DZ
browser/base/content/aboutNetError.xhtml
--- a/browser/base/content/aboutNetError.xhtml
+++ b/browser/base/content/aboutNetError.xhtml
@@ -250,17 +250,17 @@
 
         window.addEventListener("AboutNetErrorOptions", function(evt) {
         // Pinning errors are of type nssFailure2
           if (getErrorCode() == "nssFailure2") {
             document.getElementById("learnMoreContainer").style.display = "block";
             let learnMoreLink = document.getElementById("learnMoreLink");
             // nssFailure2 also gets us other non-overrideable errors. Choose
             // a "learn more" link based on description:
-            if (getDescription().includes("mozilla_pkix_error_key_pinning_failure")) {
+            if (getDescription().includes("MOZILLA_PKIX_ERROR_KEY_PINNING_FAILURE")) {
               learnMoreLink.href = "https://support.mozilla.org/kb/certificate-pinning-reports";
             }
 
             var options = JSON.parse(evt.detail);
             if (options && options.enabled) {
               var checkbox = document.getElementById("automaticallyReportInFuture");
               showCertificateErrorReporting();
               if (options.automatic) {