Bug 1346647 - Fix RDM button for undocked toolbox. r=ochameau draft
authorJ. Ryan Stinnett <jryans@gmail.com>
Tue, 14 Mar 2017 18:41:23 -0500
changeset 498551 cf5f24e225fe5f1b66ed5ae505faee373dd1a045
parent 497813 727412152afc7cf3530ce0fd9f2199aa84aa33a0
child 500744 6e4b5ca73c37c25a68cdcd4a58c7eccd905ab5d2
child 500888 50f24ce17e92b81a4dda7fa746356cea7d4d1921
push id49239
push userbmo:jryans@gmail.com
push dateTue, 14 Mar 2017 23:42:08 +0000
reviewersochameau
bugs1346647
milestone55.0a1
Bug 1346647 - Fix RDM button for undocked toolbox. r=ochameau MozReview-Commit-ID: 15axErkUY1E
devtools/client/definitions.js
--- a/devtools/client/definitions.js
+++ b/devtools/client/definitions.js
@@ -506,21 +506,20 @@ exports.ToolboxButtons = [
       ScratchpadManager.openScratchpad();
     }
   },
   { id: "command-button-responsive",
     description: l10n("toolbox.buttons.responsive",
                       osString == "Darwin" ? "Cmd+Opt+M" : "Ctrl+Shift+M"),
     isTargetSupported: target => target.isLocalTab,
     onClick(event, toolbox) {
-      let browserWindow = toolbox.win.top;
-      ResponsiveUIManager.handleGcliCommand(browserWindow,
-        browserWindow.gBrowser.selectedTab,
-        "resize toggle",
-        null);
+      let tab = toolbox.target.tab;
+      let browserWindow = tab.ownerDocument.defaultView;
+      ResponsiveUIManager.handleGcliCommand(browserWindow, tab,
+        "resize toggle", null);
     },
     isChecked(toolbox) {
       if (!toolbox.target.tab) {
         return false;
       }
       return ResponsiveUIManager.isActiveForTab(toolbox.target.tab);
     },
     setup(toolbox, onChange) {