Bug 1344016 - Use variables for updated styles r?jdescottes draft
authorMark Striemer <mstriemer@mozilla.com>
Tue, 14 Mar 2017 15:30:40 -0500
changeset 498478 abd437c255cf22b02bffcb034027d87fd406da8d
parent 498477 7bf946618eb880ed06d71e09d5da298693643fff
child 500876 18dd2be99cb069de46b12492d37b4230391ec2ac
child 500877 2a339d3bdd85e99586bb104c59d5af2f4e8b0f5e
child 500879 8904649c6f298905817bbc04cc8c0dce9a7f1ecd
push id49202
push userbmo:mstriemer@mozilla.com
push dateTue, 14 Mar 2017 20:31:43 +0000
reviewersjdescottes
bugs1344016
milestone55.0a1
Bug 1344016 - Use variables for updated styles r?jdescottes MozReview-Commit-ID: 7R66vC0qeRm
devtools/client/aboutdebugging/aboutdebugging.css
--- a/devtools/client/aboutdebugging/aboutdebugging.css
+++ b/devtools/client/aboutdebugging/aboutdebugging.css
@@ -193,37 +193,53 @@ button {
   height: 100%;
 }
 
 .error-page .error-page-details {
   color: gray;
 }
 
 .AddonTarget {
+  --AddonTarget-padding-value: 16;
+  --AddonTarget-padding-y-value: 20;
+  --AddonTarget-button-padding-value: 4;
+
+  /* Overall padding. */
+  --AddonTarget-padding: calc(var(--AddonTarget-padding-value) * 1px);
+  /* Spacing between boxes. */
+  --AddonTarget-spacing: calc(var(--AddonTarget-padding-value) * 0.5px);
+  /* Additional padding on top/bottom. */
+  --AddonTarget-padding-y: calc((var(--AddonTarget-padding-y-value) - var(--AddonTarget-padding-value)) * 1px);
+  /* Add some padding and subtract it from the margin for buttons so they're clickier. */
+  --AddonTarget-button-padding: calc(var(--AddonTarget-button-padding-value) * 1px);
+  --AddonTarget-button-margin: calc((var(--AddonTarget-padding-value) - var(--AddonTarget-button-padding-value)) * 1px);
+}
+
+.AddonTarget {
   background: #fff;
   box-shadow: 0 0 1px rgba(0,0,0,0.12);
   list-style-type: none;
-  margin: 0 0 8px;
-  padding: 4px 16px;
+  margin: 0 0 var(--AddonTarget-spacing);
+  padding: var(--AddonTarget-padding-y) var(--AddonTarget-padding);
   transition: box-shadow 150ms;
 }
 
 .AddonTarget:hover {
   box-shadow: 0 1px 2px rgba(0,0,0,0.24);
 }
 
 .AddonTarget-header {
   border-bottom: 1px solid rgba(0, 0, 0, 0.2);
   display: flex;
-  padding: 16px 0;
+  padding: var(--AddonTarget-padding) 0;
 }
 
 .AddonTarget-icon {
   height: 24px;
-  margin-inline-end: 16px;
+  margin-inline-end: var(--AddonTarget-padding);
 }
 
 .AddonTarget-icon:not([src]) {
   display: none;
 }
 
 .inverted-icons .AddonTarget-icon {
   filter: invert(30%);
@@ -235,19 +251,19 @@ button {
   font-weight: 600;
 }
 
 .AddonTarget-button {
   background: none;
   border: none;
   color: #0087ff;
   font-size: 14px;
-  margin: 12px;
+  margin: var(--AddonTarget-button-margin);
   min-width: auto;
-  padding: 4px;
+  padding: var(--AddonTarget-button-padding);
   transition: color 150ms;
 }
 
 .AddonTarget-button:active,
 .AddonTarget-button:hover,
 .AddonTarget-button:enabled:hover:active {
   background: none;
 }
@@ -268,10 +284,10 @@ button {
 .AddonTarget-button:enabled:hover:active {
   color: #003399;
   text-decoration: none;
 }
 
 .AddonTarget-button:first-of-type {
   /* Subtract the start padding so the button is still a bigger click target but
    * lines up with the icon. */
-  margin-inline-start: -4px;
+  margin-inline-start: calc(-1 * var(--AddonTarget-button-padding));
 }