Bug 1323723: reject setup value actpass in answers. r?bwc draft
authorNils Ohlmeier [:drno] <drno@ohlmeier.org>
Mon, 13 Mar 2017 21:38:25 -0700
changeset 498508 468af317341243087dfb4afeca59e71d2c39e0d0
parent 498507 b66168dc2e4c739b34b38f5e518ddec7ea330f6c
child 498509 476bd4b48c83f782791c5ccba652834abf7f4dc4
child 499535 cfec0f26ebbb30a11b37e3c060cda3d01a9ade65
push id49219
push userdrno@ohlmeier.org
push dateTue, 14 Mar 2017 22:01:56 +0000
reviewersbwc
bugs1323723
milestone55.0a1
Bug 1323723: reject setup value actpass in answers. r?bwc MozReview-Commit-ID: FnuiLB6OjbL
media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp
--- a/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp
+++ b/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp
@@ -2047,16 +2047,23 @@ JsepSessionImpl::ValidateAnswer(const Sd
         offerAttrs.HasAttribute(SdpAttribute::kMidAttribute) &&
         offerAttrs.GetMid() != answerAttrs.GetMid()) {
       JSEP_SET_ERROR("Answer changes mid for level, was \'"
                      << offerMsection.GetAttributeList().GetMid()
                      << "\', now \'"
                      << answerMsection.GetAttributeList().GetMid() << "\'");
       return NS_ERROR_INVALID_ARG;
     }
+
+    if (answerAttrs.HasAttribute(SdpAttribute::kSetupAttribute, true) &&
+        answerAttrs.GetSetup().mRole == SdpSetupAttribute::kActpass) {
+      JSEP_SET_ERROR("Answer contains illegal setup attribute \"actpass\""
+                     " at level " << i);
+      return NS_ERROR_INVALID_ARG;
+    }
   }
 
   return NS_OK;
 }
 
 nsresult
 JsepSessionImpl::CreateReceivingTrack(size_t mline,
                                       const Sdp& sdp,