Bug 1339848 - Simplify the string used to indicate that permanent access to the screen cannot be granted. r=florian draft
authorNihanth Subramanya <nhnt11@gmail.com>
Mon, 13 Mar 2017 19:33:41 +0530
changeset 497537 e849a1e5205525d65bc9d50555402fda8b8dafe2
parent 497206 f9362554866b327700c7f9b18050d7b7eb3d2b23
child 548920 284fd2d55110e591ae2ad847180757b32f24af76
push id48935
push usernhnt11@gmail.com
push dateMon, 13 Mar 2017 14:04:34 +0000
reviewersflorian
bugs1339848
milestone55.0a1
Bug 1339848 - Simplify the string used to indicate that permanent access to the screen cannot be granted. r=florian MozReview-Commit-ID: I5CqUq6QNl7
browser/locales/en-US/chrome/browser/browser.properties
browser/modules/webrtcUI.jsm
--- a/browser/locales/en-US/chrome/browser/browser.properties
+++ b/browser/locales/en-US/chrome/browser/browser.properties
@@ -633,21 +633,21 @@ getUserMedia.shareApplicationWindowCount
 #                    getUserMedia.dontAllow.label):
 # These two buttons are the possible answers to the various prompts in the
 # "getUserMedia.share{device}.message" strings.
 getUserMedia.allow.label = Allow
 getUserMedia.allow.accesskey = A
 getUserMedia.dontAllow.label = Don’t Allow
 getUserMedia.dontAllow.accesskey = D
 getUserMedia.remember=Remember this decision
-# LOCALIZATION NOTE (getUserMedia.reasonForNoPermanentAllow.screen2,
+# LOCALIZATION NOTE (getUserMedia.reasonForNoPermanentAllow.screen3,
 #                    getUserMedia.reasonForNoPermanentAllow.audio,
 #                    getUserMedia.reasonForNoPermanentAllow.insecure):
 # %S is brandShortName
-getUserMedia.reasonForNoPermanentAllow.screen2=%S can not allow permanent access to your screen without asking which one to share.
+getUserMedia.reasonForNoPermanentAllow.screen3=%S can not allow permanent access to your screen.
 getUserMedia.reasonForNoPermanentAllow.audio=%S can not allow permanent access to your tab’s audio without asking which tab to share.
 getUserMedia.reasonForNoPermanentAllow.insecure=Your connection to this site is not secure. To protect you, %S will only allow access for this session.
 
 getUserMedia.sharingMenu.label = Tabs sharing devices
 getUserMedia.sharingMenu.accesskey = d
 # LOCALIZATION NOTE (getUserMedia.sharingMenuCamera
 #                    getUserMedia.sharingMenuMicrophone,
 #                    getUserMedia.sharingMenuAudioCapture,
--- a/browser/modules/webrtcUI.jsm
+++ b/browser/modules/webrtcUI.jsm
@@ -434,17 +434,17 @@ function prompt(aBrowser, aRequest) {
 
   let productName = gBrandBundle.GetStringFromName("brandShortName");
 
   // Disable the permanent 'Allow' action if the connection isn't secure, or for
   // screen/audio sharing (because we can't guess which window the user wants to
   // share without prompting).
   let reasonForNoPermanentAllow = "";
   if (sharingScreen) {
-    reasonForNoPermanentAllow = "getUserMedia.reasonForNoPermanentAllow.screen2";
+    reasonForNoPermanentAllow = "getUserMedia.reasonForNoPermanentAllow.screen3";
   } else if (sharingAudio) {
     reasonForNoPermanentAllow = "getUserMedia.reasonForNoPermanentAllow.audio";
   } else if (!aRequest.secure) {
     reasonForNoPermanentAllow = "getUserMedia.reasonForNoPermanentAllow.insecure";
   }
 
   let options = {
     persistent: true,