Bug 1346655 - Cascade animation-name property ealier than other animation properties. r?heycam draft
authorHiroyuki Ikezoe <hikezoe@mozilla.com>
Mon, 13 Mar 2017 06:18:32 +0900
changeset 497225 30ca725d6e879e7de9e89ddd50cd59814df57244
parent 497224 9bc2b0c8441e596b38212e5774a33b5b3f75e424
child 497226 3c7cf2ff8327e9f119662aa1ebd47f936a444af7
push id48837
push userhikezoe@mozilla.com
push dateSun, 12 Mar 2017 21:19:08 +0000
reviewersheycam
bugs1346655
milestone55.0a1
Bug 1346655 - Cascade animation-name property ealier than other animation properties. r?heycam As per the CSS Animations spec, in the case when multiple values for an animation property are set, if the value length is less than the length of animation name property, then shortage values are filled up. Because of this we need to know the length of animation-name proper before we set other animation properties, so we need to cascade animation-name property earlier than other animation properties. We do the same thing for transition-property. MozReview-Commit-ID: 6xGznOR0FSN
servo/components/style/properties/properties.mako.rs
--- a/servo/components/style/properties/properties.mako.rs
+++ b/servo/components/style/properties/properties.mako.rs
@@ -1952,16 +1952,18 @@ pub fn apply_declarations<'a, F, I>(view
                 PropertyDeclaration::Color(_) |
                 PropertyDeclaration::Position(_) |
                 PropertyDeclaration::Float(_) |
                 PropertyDeclaration::TextDecorationLine(_) |
                 PropertyDeclaration::WritingMode(_) |
                 PropertyDeclaration::Direction(_)
                 % if product == 'gecko':
                     | PropertyDeclaration::TextOrientation(_)
+                    | PropertyDeclaration::AnimationName(_)
+                    | PropertyDeclaration::TransitionProperty(_)
                 % endif
             );
             if
                 % if category_to_cascade_now == "early":
                     !
                 % endif
                 is_early_property
             {