Bug 1346390 - Use Long.parseLong instead of Long.valueOf for efficiency r=nalexander draft
authorGrigory Kruglov <gkruglov@mozilla.com>
Fri, 10 Mar 2017 13:17:51 -0800
changeset 496891 6f23bf647d8547a2f711d418ba2801c5059e0ab8
parent 496768 a8d497b09753c91783b68c5805c64f34a2f39629
child 548741 dd723d17d1b409b9ad93974596b2b967db625fa7
push id48734
push usergkruglov@mozilla.com
push dateFri, 10 Mar 2017 21:23:17 +0000
reviewersnalexander
bugs1346390
milestone55.0a1
Bug 1346390 - Use Long.parseLong instead of Long.valueOf for efficiency r=nalexander MozReview-Commit-ID: 29fwjlxRqZ3
mobile/android/services/src/main/java/org/mozilla/gecko/fxa/authenticator/AndroidFxAccount.java
--- a/mobile/android/services/src/main/java/org/mozilla/gecko/fxa/authenticator/AndroidFxAccount.java
+++ b/mobile/android/services/src/main/java/org/mozilla/gecko/fxa/authenticator/AndroidFxAccount.java
@@ -833,20 +833,20 @@ public class AndroidFxAccount {
 
   public synchronized long getDeviceRegistrationTimestamp() {
     final String timestampStr = accountManager.getUserData(account, ACCOUNT_KEY_DEVICE_REGISTRATION_TIMESTAMP);
 
     if (TextUtils.isEmpty(timestampStr)) {
       return 0L;
     }
 
-    // Long.valueOf might throw; while it's not expected that this might happen, let's not risk
+    // Long.parseLong might throw; while it's not expected that this might happen, let's not risk
     // crashing here as this method will be called on startup.
     try {
-      return Long.valueOf(timestampStr);
+      return Long.parseLong(timestampStr);
     } catch (NumberFormatException e) {
       Logger.warn(LOG_TAG, "Couldn't parse deviceRegistrationTimestamp; defaulting to 0L.", e);
       return 0L;
     }
   }
 
   public synchronized void setDeviceId(String id) {
     accountManager.setUserData(account, ACCOUNT_KEY_DEVICE_ID, id);