Bug 1330348 - get() command should not automatically focus tab. draft
authorHenrik Skupin <mail@hskupin.info>
Thu, 09 Mar 2017 11:49:53 +0100
changeset 495855 0eac1d9fa110e3cc5634c9a4cc09c6422df6f1bb
parent 494684 3d341b9ba5353b6b8ab45b6ca03dcb1b2d789faa
child 495856 9261c0ccb392d3230727204a53d80c795cbb7b3e
push id48448
push userbmo:hskupin@gmail.com
push dateThu, 09 Mar 2017 11:26:19 +0000
bugs1330348
milestone55.0a1
Bug 1330348 - get() command should not automatically focus tab. The spec doesn't say something about a requirement to focus the tab when a navigation request is happening. Also it would break tests when navigation requests are issued for background tabs. MozReview-Commit-ID: JTUKq55UBCH
testing/marionette/driver.js
--- a/testing/marionette/driver.js
+++ b/testing/marionette/driver.js
@@ -963,17 +963,16 @@ GeckoDriver.prototype.get = function*(cm
     cmd.parameters.command_id = id;
     cmd.parameters.pageTimeout = this.timeouts.pageLoad;
     this.mm.broadcastAsyncMessage(
         "Marionette:pollForReadyState" + this.curBrowser.curFrameId,
         cmd.parameters);
   });
 
   yield get;
-  browser.getBrowserForTab(this.curBrowser.tab).focus();
 };
 
 /**
  * Get a string representing the current URL.
  *
  * On Desktop this returns a string representation of the URL of the
  * current top level browsing context.  This is equivalent to
  * document.location.href.