Bug 1315601 part 7 - Simplify ConditionRule. r=heycam draft
authorXidorn Quan <me@upsuper.org>
Fri, 24 Feb 2017 14:12:23 +1100
changeset 497343 078ee67ece475cbf68f7395624abfa4e17cbc42c
parent 497342 3dc10330853b1e486be83aec6d11388c8bbe8dac
child 497344 6051886a6695e01f811fecdcdbf2274b2dd470e9
push id48869
push userxquan@mozilla.com
push dateMon, 13 Mar 2017 06:50:23 +0000
reviewersheycam
bugs1315601
milestone55.0a1
Bug 1315601 part 7 - Simplify ConditionRule. r=heycam MozReview-Commit-ID: 1Ip53AOirbi
layout/style/GroupRule.cpp
layout/style/GroupRule.h
--- a/layout/style/GroupRule.cpp
+++ b/layout/style/GroupRule.cpp
@@ -361,29 +361,11 @@ GroupRule::SizeOfExcludingThis(MallocSiz
   }
 
   // Measurement of the following members may be added later if DMD finds it is
   // worthwhile:
   // - mRuleCollection
   return n;
 }
 
-// -------------------------------
-// ConditionRule
-//
-
-ConditionRule::ConditionRule(uint32_t aLineNumber, uint32_t aColumnNumber)
-  : GroupRule(aLineNumber, aColumnNumber)
-{
-}
-
-ConditionRule::ConditionRule(const ConditionRule& aCopy)
-  : GroupRule(aCopy)
-{
-}
-
-ConditionRule::~ConditionRule()
-{
-}
-
 
 } // namespace css
 } // namespace mozill
--- a/layout/style/GroupRule.h
+++ b/layout/style/GroupRule.h
@@ -96,22 +96,19 @@ protected:
   IncrementalClearCOMRuleArray mRules;
   RefPtr<GroupRuleRuleList> mRuleCollection; // lazily constructed
 };
 
 // Implementation of WebIDL CSSConditionRule.
 class ConditionRule : public GroupRule
 {
 protected:
-  ConditionRule(uint32_t aLineNumber, uint32_t aColumnNumber);
-  ConditionRule(const ConditionRule& aCopy);
-  virtual ~ConditionRule();
+  using GroupRule::GroupRule;
 
 public:
-
   // GetConditionText signature matches nsIDOMCSSConditionRule, so subclasses
   // can implement this easily.  The implementations should never return
   // anything other than NS_OK.
   NS_IMETHOD GetConditionText(nsAString& aConditionText) = 0;
   virtual void SetConditionText(const nsAString& aConditionText,
                                 ErrorResult& aRv) = 0;
 };