Bug 1345626 - remove KeyedHistogram::GetDataset; r?Dexter draft
authorTom Tromey <tom@tromey.com>
Wed, 08 Mar 2017 14:39:24 -0700
changeset 495476 6c10c4e06d70f6fcff1ab66ab0b4a1925c14d1ea
parent 495475 4efef03679907cc1bcabfb9fb150f52381f3ff0f
child 495480 461d62951d6c85c596b815bad32da368548d82d9
push id48344
push userbmo:ttromey@mozilla.com
push dateWed, 08 Mar 2017 21:40:26 +0000
reviewersDexter
bugs1345626
milestone55.0a1
Bug 1345626 - remove KeyedHistogram::GetDataset; r?Dexter MozReview-Commit-ID: 8I7WKHfl0RA
toolkit/components/telemetry/TelemetryHistogram.cpp
--- a/toolkit/components/telemetry/TelemetryHistogram.cpp
+++ b/toolkit/components/telemetry/TelemetryHistogram.cpp
@@ -869,17 +869,16 @@ namespace {
 class KeyedHistogram {
 public:
   KeyedHistogram(const nsACString &name, const nsACString &expiration,
                  uint32_t histogramType, uint32_t min, uint32_t max,
                  uint32_t bucketCount, uint32_t dataset);
   nsresult GetHistogram(const nsCString& name, Histogram** histogram, bool subsession);
   Histogram* GetHistogram(const nsCString& name, bool subsession);
   uint32_t GetHistogramType() const { return mHistogramType; }
-  nsresult GetDataset(uint32_t* dataset) const;
   nsresult GetJSKeys(JSContext* cx, JS::CallArgs& args);
   nsresult GetJSSnapshot(JSContext* cx, JS::Handle<JSObject*> obj,
                          bool subsession, bool clearSubsession);
 
   void SetRecordingEnabled(bool aEnabled) { mRecordingEnabled = aEnabled; };
   bool IsRecordingEnabled() const { return mRecordingEnabled; };
 
   nsresult Add(const nsCString& key, uint32_t aSample);
@@ -980,24 +979,16 @@ KeyedHistogram::GetHistogram(const nsCSt
   Histogram* h = nullptr;
   if (NS_FAILED(GetHistogram(key, &h, subsession))) {
     return nullptr;
   }
   return h;
 }
 
 nsresult
-KeyedHistogram::GetDataset(uint32_t* dataset) const
-{
-  MOZ_ASSERT(dataset);
-  *dataset = mDataset;
-  return NS_OK;
-}
-
-nsresult
 KeyedHistogram::Add(const nsCString& key, uint32_t sample)
 {
   bool canRecordDataset = CanRecordDataset(mDataset,
                                            internal_CanRecordBase(),
                                            internal_CanRecordExtended());
   if (!canRecordDataset) {
     return NS_OK;
   }