Bug 1086549 - Converting Sync tests from removePage to History.remove. Patch by Yoric, updated by Standard8. r?markh draft
authorDavid Rajchenbach-Teller <dteller@mozilla.com>
Fri, 24 Oct 2014 14:57:02 +0200
changeset 498328 3b3bd1869ba2beddc2aa5fd9fb433cbd9edae814
parent 498327 ae6ed8804835329424977564b6d6d3cccf0ff20d
child 498329 a1f1e386c19f48f2865c961aa2eb816c99ffb1f7
push id49145
push userbmo:standard8@mozilla.com
push dateTue, 14 Mar 2017 15:05:49 +0000
reviewersmarkh
bugs1086549
milestone55.0a1
Bug 1086549 - Converting Sync tests from removePage to History.remove. Patch by Yoric, updated by Standard8. r?markh MozReview-Commit-ID: 3dZljFrvJUA
services/sync/tests/unit/test_history_tracker.js
--- a/services/sync/tests/unit/test_history_tracker.js
+++ b/services/sync/tests/unit/test_history_tracker.js
@@ -192,17 +192,17 @@ add_task(async function test_track_delet
   await addVisit("track_delete");
   let uri = Utils.makeURI("http://getfirefox.com/track_delete");
   let guid = engine._store.GUIDForUri(uri);
   await verifyTrackerEmpty();
 
   await startTracking();
   let visitRemovedPromise = promiseVisit("removed", uri);
   let scorePromise = promiseOneObserver("weave:engine:score:updated");
-  PlacesUtils.history.removePage(uri);
+  await PlacesUtils.history.remove(uri);
   await Promise.all([scorePromise, visitRemovedPromise]);
 
   await verifyTrackedItems([guid]);
   do_check_eq(tracker.score, SCORE_INCREMENT_XLARGE);
 
   await cleanup();
 });
 
@@ -217,17 +217,17 @@ add_task(async function test_dont_track_
   await startTracking();
   let visitRemovedPromise = promiseVisit("removed", uriToRemove);
   let scorePromise = promiseOneObserver("weave:engine:score:updated");
 
   // Observe expiration.
   Services.obs.addObserver(function onExpiration(aSubject, aTopic, aData) {
     Services.obs.removeObserver(onExpiration, aTopic);
     // Remove the remaining page to update its score.
-    PlacesUtils.history.removePage(uriToRemove);
+    PlacesUtils.history.remove(uriToRemove);
   }, PlacesUtils.TOPIC_EXPIRATION_FINISHED, false);
 
   // Force expiration of 1 entry.
   Services.prefs.setIntPref("places.history.expiration.max_pages", 0);
   Cc["@mozilla.org/places/expiration;1"]
     .getService(Ci.nsIObserver)
     .observe(null, "places-debug-start-expiration", 1);