Bug 1345413 - Don't crash if LOGNAME is not set in the environment, r?glandium draft
authorBenjamin Smedberg <benjamin@smedbergs.us>
Wed, 08 Mar 2017 08:27:26 -0500
changeset 495218 539a1e358f35cfbf2fe7661735133641d7137c1d
parent 494703 74a49c067dce8277a299bcebda68ca296c799fe1
child 548317 2ac8cca628f3ad3aba8b86f31d9e9af9bfad4bb9
push id48268
push userbsmedberg@mozilla.com
push dateWed, 08 Mar 2017 13:28:07 +0000
reviewersglandium
bugs1345413
milestone55.0a1
Bug 1345413 - Don't crash if LOGNAME is not set in the environment, r?glandium MozReview-Commit-ID: BA6swHHuPc6
toolkit/xre/nsAppRunner.cpp
--- a/toolkit/xre/nsAppRunner.cpp
+++ b/toolkit/xre/nsAppRunner.cpp
@@ -3808,16 +3808,19 @@ XREMain::XRE_mainStartup(bool* aExitFlag
     }
   }
 
   if (!newInstance) {
     nsAutoCString program(gAppData->remotingName);
     ToLowerCase(program);
 
     const char* username = getenv("LOGNAME");
+    if (!username) {
+      username = "";
+    }
     const char* profile  = nullptr;
 
     RemoteResult rr = ParseRemoteCommandLine(program, &profile, &username);
     if (rr == REMOTE_ARG_BAD) {
       return 1;
     }
 
     nsCOMPtr<nsIFile> mutexDir;