Bug 1344073 - Adding consistent formatting to HTMLMediaElement::MozRequestDebugInfo debugInfo dump string. r?cpearce
MozReview-Commit-ID: GfRrLQcebbt
--- a/dom/media/MediaDecoder.cpp
+++ b/dom/media/MediaDecoder.cpp
@@ -1791,17 +1791,18 @@ MediaDecoder::NextFrameBufferedStatus()
? MediaDecoderOwner::NEXT_FRAME_AVAILABLE
: MediaDecoderOwner::NEXT_FRAME_UNAVAILABLE;
}
nsCString
MediaDecoder::GetDebugInfo()
{
return nsPrintfCString(
- "channels=%u rate=%u hasAudio=%d hasVideo=%d mPlayState=%s mdsm=%p",
+ "MediaDecoder State: channels=%u rate=%u hasAudio=%d hasVideo=%d "
+ "mPlayState=%s mdsm=%p",
mInfo ? mInfo->mAudio.mChannels : 0, mInfo ? mInfo->mAudio.mRate : 0,
mInfo ? mInfo->HasAudio() : 0, mInfo ? mInfo->HasVideo() : 0,
PlayStateStr(), GetStateMachine());
}
void
MediaDecoder::DumpDebugInfo()
{
--- a/dom/media/MediaDecoderStateMachine.cpp
+++ b/dom/media/MediaDecoderStateMachine.cpp
@@ -3779,21 +3779,22 @@ uint32_t MediaDecoderStateMachine::GetAm
: std::max<uint32_t>(sVideoQueueDefaultSize, MIN_VIDEO_QUEUE_SIZE);
}
nsCString
MediaDecoderStateMachine::GetDebugInfo()
{
MOZ_ASSERT(OnTaskQueue());
return nsPrintfCString(
- "GetMediaTime=%" PRId64 " GetClock=%" PRId64 " mMediaSink=%p "
- "state=%s mPlayState=%d mSentFirstFrameLoadedEvent=%d IsPlaying=%d "
- "mAudioStatus=%s mVideoStatus=%s mDecodedAudioEndTime=%" PRId64
- " mDecodedVideoEndTime=%" PRId64
- " mAudioCompleted=%d mVideoCompleted=%d ",
+ "MediaDecoderStateMachine State: GetMediaTime=%" PRId64 " GetClock="
+ "%" PRId64 " mMediaSink=%p state=%s mPlayState=%d "
+ "mSentFirstFrameLoadedEvent=%d IsPlaying=%d mAudioStatus=%s "
+ "mVideoStatus=%s mDecodedAudioEndTime=%" PRId64
+ " mDecodedVideoEndTime=%" PRId64 "mAudioCompleted=%d "
+ "mVideoCompleted=%d",
GetMediaTime(), mMediaSink->IsStarted() ? GetClock() : -1,
mMediaSink.get(), ToStateStr(), mPlayState.Ref(),
mSentFirstFrameLoadedEvent, IsPlaying(), AudioRequestStatus(),
VideoRequestStatus(), mDecodedAudioEndTime, mDecodedVideoEndTime,
mAudioCompleted, mVideoCompleted)
+ mStateObj->GetDebugInfo() + nsCString("\n")
+ mMediaSink->GetDebugInfo();
}
--- a/dom/media/MediaFormatReader.cpp
+++ b/dom/media/MediaFormatReader.cpp
@@ -2983,24 +2983,24 @@ MediaFormatReader::GetMozDebugReaderData
MutexAutoLock lock(mAudio.mMutex);
audioName = mAudio.mDescription;
}
if (HasVideo()) {
MutexAutoLock mon(mVideo.mMutex);
videoName = mVideo.mDescription;
}
- result += nsPrintfCString("audio decoder: %s\n", audioName);
- result += nsPrintfCString("audio frames decoded: %" PRIu64 "\n",
+ result += nsPrintfCString("Audio Decoder: %s\n", audioName);
+ result += nsPrintfCString("Audio Frames Decoded: %" PRIu64 "\n",
mAudio.mNumSamplesOutputTotal);
if (HasAudio()) {
result += nsPrintfCString(
- "audio state: ni=%d no=%d wp:%d demuxr:%d demuxq:%u decoder:%d tt:%.1f "
- "tths:%d in:%" PRIu64 " out:%" PRIu64
- " qs=%u pending:%u wfd:%d wfk:%d sid:%u\n",
+ "Audio State: ni=%d no=%d wp=%d demuxr=%d demuxq=%u decoder=%d tt=%.1f "
+ "tths=%d in=%" PRIu64 " out=%" PRIu64
+ " qs=%u pending=%u wfd=%d wfk=%d sid=%u\n",
NeedInput(mAudio),
mAudio.HasPromise(),
!mAudio.mWaitingPromise.IsEmpty(),
mAudio.mDemuxRequest.Exists(),
uint32_t(mAudio.mQueuedSamples.Length()),
mAudio.mDecodeRequest.Exists(),
mAudio.mTimeThreshold ? mAudio.mTimeThreshold.ref().Time().ToSeconds()
: -1.0,
@@ -3008,29 +3008,29 @@ MediaFormatReader::GetMozDebugReaderData
mAudio.mNumSamplesInput,
mAudio.mNumSamplesOutput,
unsigned(size_t(mAudio.mSizeOfQueue)),
unsigned(mAudio.mOutput.Length()),
mAudio.mWaitingForData,
mAudio.mWaitingForKey,
mAudio.mLastStreamSourceID);
}
- result += nsPrintfCString("video decoder: %s\n", videoName);
+ result += nsPrintfCString("Video Decoder: %s\n", videoName);
result +=
- nsPrintfCString("hardware video decoding: %s\n",
+ nsPrintfCString("Hardware Video Decoding: %s\n",
VideoIsHardwareAccelerated() ? "enabled" : "disabled");
result +=
- nsPrintfCString("video frames decoded: %" PRIu64 " (skipped:%" PRIu64 ")\n",
+ nsPrintfCString("Video Frames Decoded: %" PRIu64 " (skipped=%" PRIu64 ")\n",
mVideo.mNumSamplesOutputTotal,
mVideo.mNumSamplesSkippedTotal);
if (HasVideo()) {
result += nsPrintfCString(
- "video state: ni=%d no=%d wp:%d demuxr:%d demuxq:%u decoder:%d tt:%.1f "
- "tths:%d in:%" PRIu64 " out:%" PRIu64
- " qs=%u pending:%u wfd:%d wfk:%d sid:%u\n",
+ "Video State: ni=%d no=%d wp=%d demuxr=%d demuxq=%u decoder=%d tt=%.1f "
+ "tths=%d in=%" PRIu64 " out=%" PRIu64
+ " qs=%u pending:%u wfd=%d wfk=%d sid=%u\n",
NeedInput(mVideo),
mVideo.HasPromise(),
!mVideo.mWaitingPromise.IsEmpty(),
mVideo.mDemuxRequest.Exists(),
uint32_t(mVideo.mQueuedSamples.Length()),
mVideo.mDecodeRequest.Exists(),
mVideo.mTimeThreshold ? mVideo.mTimeThreshold.ref().Time().ToSeconds()
: -1.0,
--- a/dom/media/eme/MediaKeys.cpp
+++ b/dom/media/eme/MediaKeys.cpp
@@ -581,27 +581,27 @@ void
MediaKeys::GetSessionsInfo(nsString& sessionsInfo)
{
for (KeySessionHashMap::Iterator it = mKeySessions.Iter();
!it.Done();
it.Next()) {
MediaKeySession* keySession = it.Data();
nsString sessionID;
keySession->GetSessionId(sessionID);
- sessionsInfo.AppendLiteral("(sid:");
+ sessionsInfo.AppendLiteral("(sid=");
sessionsInfo.Append(sessionID);
MediaKeyStatusMap* keyStatusMap = keySession->KeyStatuses();
for (uint32_t i = 0; i < keyStatusMap->GetIterableLength(); i++) {
nsString keyID = keyStatusMap->GetKeyIDAsHexString(i);
- sessionsInfo.AppendLiteral("(kid:");
+ sessionsInfo.AppendLiteral("(kid=");
sessionsInfo.Append(keyID);
using IntegerType = typename std::underlying_type<MediaKeyStatus>::type;
auto idx = static_cast<IntegerType>(keyStatusMap->GetValueAtIndex(i));
const char* keyStatus = MediaKeyStatusValues::strings[idx].value;
- sessionsInfo.AppendLiteral(" status:");
+ sessionsInfo.AppendLiteral(" status=");
sessionsInfo.Append(
NS_ConvertUTF8toUTF16((nsDependentCString(keyStatus))));
sessionsInfo.AppendLiteral(")");
}
sessionsInfo.AppendLiteral(")");
}
}
--- a/dom/media/mediasink/VideoSink.cpp
+++ b/dom/media/mediasink/VideoSink.cpp
@@ -474,18 +474,19 @@ VideoSink::MaybeResolveEndPromise()
}
}
nsCString
VideoSink::GetDebugInfo()
{
AssertOwnerThread();
return nsPrintfCString(
- "IsStarted=%d IsPlaying=%d, VideoQueue: finished=%d size=%" PRIuSIZE ", "
- "mVideoFrameEndTime=%" PRId64 " mHasVideo=%d mVideoSinkEndRequest.Exists()=%d "
- "mEndPromiseHolder.IsEmpty()=%d\n",
- IsStarted(), IsPlaying(), VideoQueue().IsFinished(), VideoQueue().GetSize(),
- mVideoFrameEndTime, mHasVideo, mVideoSinkEndRequest.Exists(), mEndPromiseHolder.IsEmpty())
+ "VideoSink Status: IsStarted=%d IsPlaying=%d VideoQueue(finished=%d "
+ "size=%" PRIuSIZE ") mVideoFrameEndTime=%" PRId64 " mHasVideo=%d "
+ "mVideoSinkEndRequest.Exists()=%d mEndPromiseHolder.IsEmpty()=%d\n",
+ IsStarted(), IsPlaying(), VideoQueue().IsFinished(),
+ VideoQueue().GetSize(), mVideoFrameEndTime, mHasVideo,
+ mVideoSinkEndRequest.Exists(), mEndPromiseHolder.IsEmpty())
+ mAudioSink->GetDebugInfo();
}
} // namespace media
} // namespace mozilla
--- a/dom/media/mediasource/MediaSourceDemuxer.cpp
+++ b/dom/media/mediasource/MediaSourceDemuxer.cpp
@@ -245,43 +245,47 @@ MediaSourceDemuxer::~MediaSourceDemuxer(
mInitPromise.RejectIfExists(NS_ERROR_DOM_MEDIA_CANCELED, __func__);
}
void
MediaSourceDemuxer::GetMozDebugReaderData(nsACString& aString)
{
MonitorAutoLock mon(mMonitor);
nsAutoCString result;
- result += nsPrintfCString("Dumping data for demuxer %p:\n", this);
+ result += nsPrintfCString("Dumping Data for Demuxer: %p\n", this);
if (mAudioTrack) {
- result += nsPrintfCString("\tDumping Audio Track Buffer(%s): - mLastAudioTime: %f\n"
- "\t\tNumSamples:%" PRIuSIZE " Size:%u Evictable:%u NextGetSampleIndex:%u NextInsertionIndex:%d\n",
+ result += nsPrintfCString("\tDumping Audio Track Buffer(%s): mLastAudioTime=%f\n"
+ "\t\tAudio Track Buffer Details: NumSamples=%"
+ PRIuSIZE " Size=%u Evictable=%u "
+ "NextGetSampleIndex=%u NextInsertionIndex=%d\n",
mAudioTrack->mAudioTracks.mInfo->mMimeType.get(),
mAudioTrack->mAudioTracks.mNextSampleTime.ToSeconds(),
mAudioTrack->mAudioTracks.mBuffers[0].Length(),
mAudioTrack->mAudioTracks.mSizeBuffer,
mAudioTrack->Evictable(TrackInfo::kAudioTrack),
mAudioTrack->mAudioTracks.mNextGetSampleIndex.valueOr(-1),
mAudioTrack->mAudioTracks.mNextInsertionIndex.valueOr(-1));
- result += nsPrintfCString("\t\tBuffered: ranges=%s\n",
+ result += nsPrintfCString("\t\tAudio Track Buffered: ranges=%s\n",
DumpTimeRanges(mAudioTrack->SafeBuffered(TrackInfo::kAudioTrack)).get());
}
if (mVideoTrack) {
- result += nsPrintfCString("\tDumping Video Track Buffer(%s) - mLastVideoTime: %f\n"
- "\t\tNumSamples:%" PRIuSIZE " Size:%u Evictable:%u NextGetSampleIndex:%u NextInsertionIndex:%d\n",
+ result += nsPrintfCString("\tDumping Video Track Buffer(%s): mLastVideoTime=%f\n"
+ "\t\tVideo Track Buffer Details: NumSamples=%"
+ PRIuSIZE " Size=%u Evictable=%u "
+ "NextGetSampleIndex=%u NextInsertionIndex=%d\n",
mVideoTrack->mVideoTracks.mInfo->mMimeType.get(),
mVideoTrack->mVideoTracks.mNextSampleTime.ToSeconds(),
mVideoTrack->mVideoTracks.mBuffers[0].Length(),
mVideoTrack->mVideoTracks.mSizeBuffer,
mVideoTrack->Evictable(TrackInfo::kVideoTrack),
mVideoTrack->mVideoTracks.mNextGetSampleIndex.valueOr(-1),
mVideoTrack->mVideoTracks.mNextInsertionIndex.valueOr(-1));
- result += nsPrintfCString("\t\tBuffered: ranges=%s\n",
+ result += nsPrintfCString("\t\tVideo Track Buffered: ranges=%s\n",
DumpTimeRanges(mVideoTrack->SafeBuffered(TrackInfo::kVideoTrack)).get());
}
aString += result;
}
MediaSourceTrackDemuxer::MediaSourceTrackDemuxer(MediaSourceDemuxer* aParent,
TrackInfo::TrackType aType,
TrackBuffersManager* aManager)