Bug 1340494 - Remove -FS option on SIMPLE_PROGRAM. r?glandium
Although
bug 1322703 is backed out, we can remove -FS options to build SIMPLE_PROGRAM.
MozReview-Commit-ID: 7uO3We5hc5n
--- a/config/rules.mk
+++ b/config/rules.mk
@@ -162,17 +162,17 @@ ifndef GNU_CC
# The final PDB for libraries and programs is created by the linker and uses
# a different name from the single PDB file created by the compiler. See
# bug 462740.
#
ifdef SIMPLE_PROGRAMS
COMPILE_PDB_FLAG ?= -Fd$(basename $(@F)).pdb
else
-COMPILE_PDB_FLAG ?= -Fdgenerated.pdb
+COMPILE_PDB_FLAG ?= -Fdgenerated.pdb -FS
endif
COMPILE_CFLAGS += $(COMPILE_PDB_FLAG)
COMPILE_CXXFLAGS += $(COMPILE_PDB_FLAG)
LINK_PDBFILE ?= $(basename $(@F)).pdb
ifdef MOZ_DEBUG
CODFILE=$(basename $(@F)).cod
endif
--- a/js/src/old-configure.in
+++ b/js/src/old-configure.in
@@ -695,20 +695,16 @@ case "$target" in
if test -z `echo $CFLAGS | grep -i [-/]arch:` ; then
CFLAGS="$CFLAGS -arch:SSE2"
fi
if test -z `echo $CXXFLAGS | grep -i [-/]arch:` ; then
CXXFLAGS="$CXXFLAGS -arch:SSE2"
fi
changequote([,])
fi
- dnl VS2013+ requires -FS when parallel building by make -jN.
- dnl If nothing, compiler sometimes causes C1041 error.
- CFLAGS="$CFLAGS -FS"
- CXXFLAGS="$CXXFLAGS -FS"
dnl VS2013+ supports -Gw for better linker optimizations.
dnl http://blogs.msdn.com/b/vcblog/archive/2013/09/11/introducing-gw-compiler-switch.aspx
dnl Disabled on ASan because it causes false-positive ODR violations.
if test -z "$MOZ_ASAN"; then
CFLAGS="$CFLAGS -Gw"
CXXFLAGS="$CXXFLAGS -Gw"
fi
# khuey says we can safely ignore MSVC warning C4251
--- a/old-configure.in
+++ b/old-configure.in
@@ -981,20 +981,16 @@ case "$target" in
dnl and doesn't have a separate arch for SSSE3
SSSE3_FLAGS="-arch:SSE2"
fi
dnl clang-cl requires appropriate flags to enable SSSE3 support
dnl on all architectures.
if test -n "$CLANG_CL"; then
SSSE3_FLAGS="-mssse3"
fi
- dnl VS2013+ requires -FS when parallel building by make -jN.
- dnl If nothing, compiler sometimes causes C1041 error.
- CFLAGS="$CFLAGS -FS"
- CXXFLAGS="$CXXFLAGS -FS"
dnl VS2013+ supports -Gw for better linker optimizations.
dnl http://blogs.msdn.com/b/vcblog/archive/2013/09/11/introducing-gw-compiler-switch.aspx
dnl Disabled on ASan because it causes false-positive ODR violations.
if test -z "$MOZ_ASAN"; then
CFLAGS="$CFLAGS -Gw"
CXXFLAGS="$CXXFLAGS -Gw"
fi
# khuey says we can safely ignore MSVC warning C4251