Bug 1344976 - Remove xml:base usage in FeedWriter. r?Gijs draft
authorXidorn Quan <me@upsuper.org>
Tue, 07 Mar 2017 12:31:46 +1100
changeset 494311 1a6c33e5d0a9e5e2b51d13c00c54cd7f9fd42922
parent 494297 89ba72cf0048e7de769dc9f77bd65a2492bf29db
child 548082 310a5d10357f6744db6863722eba603a002c9ae4
push id48013
push userxquan@mozilla.com
push dateTue, 07 Mar 2017 01:33:01 +0000
reviewersGijs
bugs1344976
milestone54.0a1
Bug 1344976 - Remove xml:base usage in FeedWriter. r?Gijs MozReview-Commit-ID: HYYTMUqrJzN
browser/components/feeds/FeedWriter.js
--- a/browser/components/feeds/FeedWriter.js
+++ b/browser/components/feeds/FeedWriter.js
@@ -174,19 +174,16 @@ FeedWriter.prototype = {
   },
 
   _setContentText(id, text) {
     let element = this._document.getElementById(id);
     let textNode = text.createDocumentFragment(element);
     while (element.hasChildNodes())
       element.removeChild(element.firstChild);
     element.appendChild(textNode);
-    if (text.base) {
-      element.setAttributeNS(XML_NS, "base", text.base.spec);
-    }
   },
 
   /**
    * Safely sets the href attribute on an anchor tag, providing the URI
    * specified can be loaded according to rules.
    * @param   element
    *          The element to set a URI attribute on
    * @param   attribute
@@ -381,18 +378,16 @@ FeedWriter.prototype = {
       let entryContainer = this._document.createElementNS(HTML_NS, "div");
       entryContainer.className = "entry";
 
       // If the entry has a title, make it a link
       if (entry.title) {
         let a = this._document.createElementNS(HTML_NS, "a");
         let span = this._document.createElementNS(HTML_NS, "span");
         a.appendChild(span);
-        if (entry.title.base)
-          span.setAttributeNS(XML_NS, "base", entry.title.base.spec);
         span.appendChild(entry.title.createDocumentFragment(a));
 
         // Entries are not required to have links, so entry.link can be null.
         if (entry.link)
           this._safeSetURIAttribute(a, "href", entry.link.spec);
 
         let title = this._document.createElementNS(HTML_NS, "h3");
         title.appendChild(a);
@@ -407,20 +402,16 @@ FeedWriter.prototype = {
 
         entryContainer.appendChild(title);
       }
 
       let body = this._document.createElementNS(HTML_NS, "div");
       let summary = entry.summary || entry.content;
       let docFragment = null;
       if (summary) {
-        if (summary.base)
-          body.setAttributeNS(XML_NS, "base", summary.base.spec);
-        else
-          LOG("no base?");
         docFragment = summary.createDocumentFragment(body);
         if (docFragment)
           body.appendChild(docFragment);
 
         // If the entry doesn't have a title, append a # permalink
         // See http://scripting.com/rss.xml for an example
         if (!entry.title && entry.link) {
           let a = this._document.createElementNS(HTML_NS, "a");