Bug 1343557 - Disable -pedantic-errors for pkix gtests; r?keeler draft
authorDan Minor <dminor@mozilla.com>
Thu, 02 Mar 2017 17:12:14 -0500
changeset 494056 d2d4e5686a68f823d011eb9eb1f4c4deb942a902
parent 494055 538e88f951285f217a58f0450e31dcdf9cbf2172
child 547993 a5c6e6011dec340b2e5c250afce7b12afb76bce9
push id47916
push userdminor@mozilla.com
push dateMon, 06 Mar 2017 14:03:31 +0000
reviewerskeeler
bugs1343557
milestone54.0a1
Bug 1343557 - Disable -pedantic-errors for pkix gtests; r?keeler MozReview-Commit-ID: FEeAF9Vm3PJ
security/pkix/test/gtest/moz.build
--- a/security/pkix/test/gtest/moz.build
+++ b/security/pkix/test/gtest/moz.build
@@ -32,16 +32,21 @@ LOCAL_INCLUDES += [
     '../../lib',
     '../lib',
 ]
 
 FINAL_LIBRARY = 'xul-gtest'
 
 include('../../warnings.mozbuild')
 
+# GTest uses a variadic macro in a questionable way and it doesn't seem to be
+# possible to selectively disable just that error when -pedantic-errors is set.
+if CONFIG['GNU_CXX'] and not CONFIG['CLANG_CXX']:
+  CXXFLAGS.remove('-pedantic-errors')
+
 # These warnings are disabled in order to minimize the amount of boilerplate
 # required to implement tests, and/or because they originate in the GTest
 # framework in a way we cannot otherwise work around.
 if CONFIG['GNU_CXX']:
   CXXFLAGS += [
     '-Wno-error=shadow',
     '-Wno-old-style-cast',
   ]