Bug 1341985 - Part 1: Use borrow() instead of borrow_mut() for PerDocumentStyleData. r?heycam draft
authorHiroyuki Ikezoe <hikezoe@mozilla.com>
Fri, 10 Mar 2017 10:32:24 +0900
changeset 496318 54dd7a409e49edf905571a0e3661cc9565fb35fd
parent 496313 35398cae65c1526ce45c23a5f8b5568c5ada4762
child 496319 8c29ccbfc44ed4dd44655e9836a4a615f2d6abfa
push id48568
push userhikezoe@mozilla.com
push dateFri, 10 Mar 2017 01:36:35 +0000
reviewersheycam
bugs1341985
milestone55.0a1
Bug 1341985 - Part 1: Use borrow() instead of borrow_mut() for PerDocumentStyleData. r?heycam We don't mutate any PerDocumentStyleData in Servo_StyleSet_FillKeyframesForName. MozReview-Commit-ID: H1uJkxEpi0I
servo/ports/geckolib/glue.rs
--- a/servo/ports/geckolib/glue.rs
+++ b/servo/ports/geckolib/glue.rs
@@ -1414,17 +1414,17 @@ pub extern "C" fn Servo_AssertTreeIsClea
 pub extern "C" fn Servo_StyleSet_FillKeyframesForName(raw_data: RawServoStyleSetBorrowed,
                                                       name: *const nsACString,
                                                       timing_function: *const nsTimingFunction,
                                                       style: ServoComputedValuesBorrowed,
                                                       keyframes: RawGeckoKeyframeListBorrowedMut) -> bool {
     use style::gecko_bindings::structs::Keyframe;
     use style::properties::LonghandIdSet;
 
-    let data = PerDocumentStyleData::from_ffi(raw_data).borrow_mut();
+    let data = PerDocumentStyleData::from_ffi(raw_data).borrow();
     let name = unsafe { Atom::from(name.as_ref().unwrap().as_str_unchecked()) };
     let style_timing_function = unsafe { timing_function.as_ref().unwrap() };
     let style = ComputedValues::as_arc(&style);
 
     if let Some(ref animation) = data.stylist.animations().get(&name) {
        for step in &animation.steps {
           // Override timing_function if the keyframe has animation-timing-function.
           let timing_function = if let Some(val) = step.get_animation_timing_function() {