bug 1343686 log a message if xpinstall.signatures.dev-root is set and install fails r?aswan draft
authorandy mckay <amckay@mozilla.com>
Wed, 01 Mar 2017 16:22:38 -0800
changeset 491630 cb6e5c9f2e660e6a279f3a3c198d4809118ab9e5
parent 490976 e150eaff1f83e4e4a97d1e30c57d233859efe9cb
child 547500 aa8aa0408364cfbc6cb574f86b7cb4569b8acedb
push id47362
push userbmo:amckay@mozilla.com
push dateThu, 02 Mar 2017 00:42:28 +0000
reviewersaswan
bugs1343686
milestone54.0a1
bug 1343686 log a message if xpinstall.signatures.dev-root is set and install fails r?aswan MozReview-Commit-ID: 6zA9rjBXyQf
toolkit/mozapps/extensions/internal/XPIProvider.jsm
--- a/toolkit/mozapps/extensions/internal/XPIProvider.jsm
+++ b/toolkit/mozapps/extensions/internal/XPIProvider.jsm
@@ -731,16 +731,19 @@ function canRunInSafeMode(aAddon) {
  */
 function isUsableAddon(aAddon) {
   // Hack to ensure the default theme is always usable
   if (aAddon.type == "theme" && aAddon.internalName == XPIProvider.defaultSkin)
     return true;
 
   if (mustSign(aAddon.type) && !aAddon.isCorrectlySigned) {
     logger.warn(`Add-on ${aAddon.id} is not correctly signed.`);
+    if (Preferences.get(PREF_XPI_SIGNATURES_DEV_ROOT, false)) {
+      logger.warn(`Preference ${PREF_XPI_SIGNATURES_DEV_ROOT} is set.`);
+    }
     return false;
   }
 
   if (aAddon.blocklistState == Blocklist.STATE_BLOCKED) {
     logger.warn(`Add-on ${aAddon.id} is blocklisted.`);
     return false;
   }