Bug 1340637 - Skip geckodriver in hazard builds; r?ted draft
authorAndreas Tolfsen <ato@mozilla.com>
Wed, 01 Mar 2017 19:38:11 +0000
changeset 491125 ac5e79e7c176e72f8adb02aa3604cbb4d775f8f7
parent 491124 875c5c8e67117d58d637fc6d4e551e90e9cb1abe
child 547465 e9a6a14822b295976ff5765003ca326c247ab880
push id47321
push userbmo:ato@mozilla.com
push dateWed, 01 Mar 2017 19:42:14 +0000
reviewersted
bugs1340637
milestone54.0a1
Bug 1340637 - Skip geckodriver in hazard builds; r?ted One of the Rust crates that is built as part of geckodriver's dependency chain uses a build script to compile some C code. Because mozbuild does not yet pass the compiler wrapper down to where the gcc crate can find it, we need to avoid building on geckodriver when this is the case. MozReview-Commit-ID: GCDedvL515S
toolkit/toolkit.mozbuild
--- a/toolkit/toolkit.mozbuild
+++ b/toolkit/toolkit.mozbuild
@@ -159,24 +159,25 @@ if 'gtk' in CONFIG['MOZ_WIDGET_TOOLKIT']
 DIRS += ['/addon-sdk']
 
 if CONFIG['ENABLE_MARIONETTE']:
     DIRS += [
         '/testing/firefox-ui',
         '/testing/marionette',
     ]
 
-    # Disable building of geckodriver for artifact build, macOS,
-    # and Android.
+    # Disable building of geckodriver for artifact builds, macOS,
+    # Android, and Hazard builds.
     #
     # https://bugzilla.mozilla.org/show_bug.cgi?id=1341041
     # https://bugzilla.mozilla.org/show_bug.cgi?id=1329737
     if CONFIG['COMPILE_ENVIRONMENT'] and \
             CONFIG['OS_ARCH'] != 'Darwin' and \
-            CONFIG['OS_TARGET'] != 'Android':
+            CONFIG['OS_TARGET'] != 'Android' and \
+            not CONFIG['MOZ_HAZARD']:
         DIRS += ['/testing/geckodriver']
 
 DIRS += [
     '/tools/quitter',
     '/media/gmp-clearkey/0.1',
 ]
 
 if CONFIG['ENABLE_TESTS']: