Bug 1343477 - Search label should be a placeholder text in Settings of Site Data, r?Gijs draft
authorFischer.json <fischer.json@gmail.com>
Wed, 01 Mar 2017 18:00:22 +0800
changeset 491742 bf8ef7ad50a5d624f25bd39dc5839a2342bfd480
parent 490433 1bc2ad020aee2830e0a7941f10958dbec108c254
child 547523 31af4b69dee7d427cba56aa4e96f4b10fbe1f647
push id47392
push userbmo:fliu@mozilla.com
push dateThu, 02 Mar 2017 03:41:13 +0000
reviewersGijs
bugs1343477
milestone54.0a1
Bug 1343477 - Search label should be a placeholder text in Settings of Site Data, r?Gijs MozReview-Commit-ID: 6ljPyss39fS
browser/components/preferences/siteDataSettings.xul
browser/locales/en-US/chrome/browser/preferences/siteDataSettings.dtd
--- a/browser/components/preferences/siteDataSettings.xul
+++ b/browser/components/preferences/siteDataSettings.xul
@@ -22,19 +22,19 @@
 
   <stringbundle id="bundlePreferences"
                 src="chrome://browser/locale/preferences/preferences.properties"/>
 
   <vbox flex="1">
     <description>&settings.description;</description>
     <separator class="thin"/>
 
-    <hbox id="searchBoxContainer" align="center">
-      <label accesskey="&search.accesskey;" control="searchBox">&search.label;</label>
-      <textbox id="searchBox" type="search" flex="1"/>
+    <hbox id="searchBoxContainer">
+      <textbox id="searchBox" type="search" flex="1"
+        placeholder="&searchPlaceHolder;" accesskey="&searchPlaceHolder.accesskey;"/>
     </hbox>
     <separator class="thin"/>
 
     <richlistbox id="sitesList" orient="vertical" flex="1">
       <listheader>
         <treecol flex="4" width="50" label="&hostCol.label;" id="hostCol"/>
         <treecol flex="2" width="50" label="&statusCol.label;" id="statusCol"/>
         <treecol flex="1" width="50" label="&usageCol.label;" id="usageCol"/>
--- a/browser/locales/en-US/chrome/browser/preferences/siteDataSettings.dtd
+++ b/browser/locales/en-US/chrome/browser/preferences/siteDataSettings.dtd
@@ -2,18 +2,18 @@
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <!ENTITY     window.title                  "Settings - Site Data">
 <!ENTITY     settings.description          "The following websites asked to store site data in your disk. You can specify which websites are allowed to store site data. Default site data is temporary and could be deleted automatically.">
 <!ENTITY     hostCol.label                 "Site">
 <!ENTITY     statusCol.label               "Status">
 <!ENTITY     usageCol.label                "Storage">
-<!ENTITY     search.label                  "Search:">
-<!ENTITY     search.accesskey              "S">
+<!ENTITY     searchPlaceHolder             "Search">
+<!ENTITY     searchPlaceHolder.accesskey   "S">
 <!ENTITY     removeSelected.label          "Remove Selected">
 <!ENTITY     removeSelected.accesskey      "r">
 <!ENTITY     save.label                    "Save Changes">
 <!ENTITY     save.accesskey                "a">
 <!ENTITY     cancel.label                  "Cancel">
 <!ENTITY     cancel.accesskey              "C">
 <!ENTITY     removingDialog.title          "Removing Site Data">
 <!ENTITY     removingDialog.description    "Removing site data will also remove cookies. This may log you out of websites and remove offline web content. Are you sure you want to make the changes?">