Bug 1342946 - Fix wrong MOZ_ASSERT(true) in places/Database.cpp. r=standard8 draft
authorMarco Bonardo <mbonardo@mozilla.com>
Tue, 28 Feb 2017 13:53:16 +0100
changeset 490452 2927f32454961578738851d35cb2bf9dd710b703
parent 489990 ecf39ae188da37206b39a31e585fdcb028bd8b7b
child 547257 d5d382f7c6fb0bfc5be09c48829533a91685bd98
push id47096
push usermak77@bonardo.net
push dateTue, 28 Feb 2017 12:54:46 +0000
reviewersstandard8
bugs1342946
milestone54.0a1
Bug 1342946 - Fix wrong MOZ_ASSERT(true) in places/Database.cpp. r=standard8 MozReview-Commit-ID: 1gkIRqN1yYE
toolkit/components/places/Database.cpp
--- a/toolkit/components/places/Database.cpp
+++ b/toolkit/components/places/Database.cpp
@@ -242,18 +242,17 @@ SetJournalMode(nsCOMPtr<mozIStorageConne
       return JOURNAL_TRUNCATE;
     }
     if (journalMode.EqualsLiteral("memory")) {
       return JOURNAL_MEMORY;
     }
     if (journalMode.EqualsLiteral("wal")) {
       return JOURNAL_WAL;
     }
-    // This is an unknown journal.
-    MOZ_ASSERT(true);
+    MOZ_ASSERT(false, "Got an unknown journal mode.");
   }
 
   return JOURNAL_DELETE;
 }
 
 nsresult
 CreateRoot(nsCOMPtr<mozIStorageConnection>& aDBConn,
            const nsCString& aRootName, const nsCString& aGuid,