Bug 1342051 - clear css grid pattern cache when destroying highlighter;r=zer0
MozReview-Commit-ID: 5LpjjzjZfs3
--- a/devtools/client/inspector/rules/test/browser_rules_grid-highlighter-on-reload.js
+++ b/devtools/client/inspector/rules/test/browser_rules_grid-highlighter-on-reload.js
@@ -25,17 +25,17 @@ add_task(function* () {
info("Check that the grid highlighter can be displayed");
yield checkGridHighlighter();
info("Close the toolbox before reloading the tab");
let target = TargetFactory.forTab(gBrowser.selectedTab);
yield gDevTools.closeToolbox(target);
- refreshTab(gBrowser.selectedTab);
+ yield refreshTab(gBrowser.selectedTab);
info("Check that the grid highlighter can be displayed after reloading the page");
yield checkGridHighlighter();
});
function* checkGridHighlighter() {
let {inspector, view} = yield openRuleView();
let {highlighters} = view;
--- a/devtools/server/actors/highlighters/css-grid.js
+++ b/devtools/server/actors/highlighters/css-grid.js
@@ -236,16 +236,19 @@ CssGridHighlighter.prototype = extend(Au
let { highlighterEnv } = this;
highlighterEnv.off("navigate", this.onNavigate);
highlighterEnv.off("will-navigate", this.onWillNavigate);
let { pageListenerTarget } = highlighterEnv;
pageListenerTarget.removeEventListener("pagehide", this.onPageHide);
this.markup.destroy();
+
+ // Clear the pattern cache to avoid dead object exceptions (Bug 1342051).
+ this._clearCache();
AutoRefreshHighlighter.prototype.destroy.call(this);
},
getElement(id) {
return this.markup.getElement(this.ID_CLASS_PREFIX + id);
},
get ctx() {