Bug 1342215 - Fix pageError stub generation. r=jdescottes
We set a listener for "pageError" but we don't remove it.
There is a `once: true` property passed as an option for addListener,
but this isn't a standard addEventListener call it does not do anything.
Reverting to remove the listener fix the issue.
MozReview-Commit-ID: CrpS1QY5jNo
--- a/devtools/client/webconsole/new-console-output/test/fixtures/stub-generators/head.js
+++ b/devtools/client/webconsole/new-console-output/test/fixtures/stub-generators/head.js
@@ -408,22 +408,21 @@ function* generatePageErrorStubs() {
packets: [],
};
let toolbox = yield openNewTabAndToolbox(TEST_URI, "webconsole");
for (let [key, code] of pageError) {
let received = new Promise(resolve => {
toolbox.target.client.addListener("pageError", function onPacket(e, packet) {
+ toolbox.target.client.removeListener("pageError", onPacket);
let message = prepareMessage(packet, {getNextId: () => 1});
stubs.packets.push(formatPacket(message.messageText, packet));
stubs.preparedMessages.push(formatStub(message.messageText, packet));
resolve();
- }, {
- once: true
});
});
yield ContentTask.spawn(
gBrowser.selectedBrowser,
[key, code],
function ([subKey, subCode]) {
let script = content.document.createElement("script");