Bug 1339504 - Use silent file copies in the Maintenance Service installer. r?agashlin draft
authorMatt Howell <mhowell@mozilla.com>
Thu, 23 Feb 2017 10:05:36 -0800
changeset 488769 ed3e88292211982361d723ace021df64ac4949eb
parent 488741 22ec1dab9e821676f4204d36ce9801803032f504
child 546824 0eb27f60970b7d51271bcf9d97e3d808ae8da152
push id46629
push usermhowell@mozilla.com
push dateThu, 23 Feb 2017 18:07:09 +0000
reviewersagashlin
bugs1339504
milestone54.0a1
Bug 1339504 - Use silent file copies in the Maintenance Service installer. r?agashlin MozReview-Commit-ID: AUse9SjJaIA
browser/installer/windows/nsis/maintenanceservice_installer.nsi
--- a/browser/installer/windows/nsis/maintenanceservice_installer.nsi
+++ b/browser/installer/windows/nsis/maintenanceservice_installer.nsi
@@ -144,24 +144,24 @@ Section "MaintenanceService"
   ; disk as maintenanceservice.exe directly.
   StrCpy $TempMaintServiceName "maintenanceservice.exe"
   IfFileExists "$INSTDIR\maintenanceservice.exe" 0 skipAlreadyExists
     StrCpy $TempMaintServiceName "maintenanceservice_tmp.exe"
   skipAlreadyExists:
 
   ; We always write out a copy and then decide whether to install it or 
   ; not via calling its 'install' cmdline which works by version comparison.
-  CopyFiles "$EXEDIR\maintenanceservice.exe" "$INSTDIR\$TempMaintServiceName"
+  CopyFiles /SILENT "$EXEDIR\maintenanceservice.exe" "$INSTDIR\$TempMaintServiceName"
 
   ; The updater.ini file is only used when performing an install or upgrade,
   ; and only if that install or upgrade is successful.  If an old updater.ini
   ; happened to be copied into the maintenance service installation directory
   ; but the service was not newer, the updater.ini file would be unused.
   ; It is used to fill the description of the service on success.
-  CopyFiles "$EXEDIR\updater.ini" "$INSTDIR\updater.ini"
+  CopyFiles /SILENT "$EXEDIR\updater.ini" "$INSTDIR\updater.ini"
 
   ; Install the application maintenance service.
   ; If a service already exists, the command line parameter will stop the
   ; service and only install itself if it is newer than the already installed
   ; service.  If successful it will remove the old maintenanceservice.exe
   ; and replace it with maintenanceservice_tmp.exe.
   ClearErrors
   ${GetParameters} $0