Bug 1190687 - [webext] Convert openContextMenu and closeContextMenu test helpers into async functions. draft
authorLuca Greco <lgreco@mozilla.com>
Wed, 22 Feb 2017 19:02:56 +0100
changeset 491931 c0707b0c89ad170b85e38e872162024e53e7ed3c
parent 491665 e91de6fb2b3dce9c932428265b0fdb630ea470d7
child 491932 29c640f8fc11c9cd00c1c3d472715c670a87703e
push id47462
push userluca.greco@alcacoop.it
push dateThu, 02 Mar 2017 14:05:01 +0000
bugs1190687
milestone54.0a1
Bug 1190687 - [webext] Convert openContextMenu and closeContextMenu test helpers into async functions. MozReview-Commit-ID: AD57ftJiVlR
browser/components/extensions/test/browser/head.js
--- a/browser/components/extensions/test/browser/head.js
+++ b/browser/components/extensions/test/browser/head.js
@@ -220,29 +220,29 @@ function closeBrowserAction(extension, w
   let group = getBrowserActionWidget(extension);
 
   let node = win.document.getElementById(group.viewId);
   CustomizableUI.hidePanelForNode(node);
 
   return Promise.resolve();
 }
 
-function* openContextMenu(selector = "#img1") {
+async function openContextMenu(selector = "#img1") {
   let contentAreaContextMenu = document.getElementById("contentAreaContextMenu");
   let popupShownPromise = BrowserTestUtils.waitForEvent(contentAreaContextMenu, "popupshown");
-  yield BrowserTestUtils.synthesizeMouseAtCenter(selector, {type: "contextmenu"}, gBrowser.selectedBrowser);
-  yield popupShownPromise;
+  await BrowserTestUtils.synthesizeMouseAtCenter(selector, {type: "contextmenu"}, gBrowser.selectedBrowser);
+  await popupShownPromise;
   return contentAreaContextMenu;
 }
 
-function* closeContextMenu() {
+async function closeContextMenu() {
   let contentAreaContextMenu = document.getElementById("contentAreaContextMenu");
   let popupHiddenPromise = BrowserTestUtils.waitForEvent(contentAreaContextMenu, "popuphidden");
   contentAreaContextMenu.hidePopup();
-  yield popupHiddenPromise;
+  await popupHiddenPromise;
 }
 
 function* openExtensionContextMenu(selector = "#img1") {
   let contextMenu = yield openContextMenu(selector);
   let topLevelMenu = contextMenu.getElementsByAttribute("ext-type", "top-level-menu");
 
   // Return null if the extension only has one item and therefore no extension menu.
   if (topLevelMenu.length == 0) {