Bug 1341450 - Repair incorrect check for missing DMDReportAndDump function. r?jmaher draft
authorKartikaya Gupta <kgupta@mozilla.com>
Tue, 21 Feb 2017 18:58:30 -0500
changeset 487695 d868abed2102bc6f085a6d4ea7854af12fe0c2f7
parent 487583 c7b015c488cfb2afbcff295a9639acd85df332f8
child 546522 6c18c9cbc478154db6f3ec0112878cba7b3a8d15
push id46298
push userkgupta@mozilla.com
push dateTue, 21 Feb 2017 23:59:01 +0000
reviewersjmaher
bugs1341450
milestone54.0a1
Bug 1341450 - Repair incorrect check for missing DMDReportAndDump function. r?jmaher MozReview-Commit-ID: 9lZEvxOYoR3
testing/mochitest/tests/SimpleTest/MemoryStats.js
--- a/testing/mochitest/tests/SimpleTest/MemoryStats.js
+++ b/testing/mochitest/tests/SimpleTest/MemoryStats.js
@@ -99,24 +99,24 @@ MemoryStats.dump = function (testNumber,
         var md = MemoryStats._getService("@mozilla.org/memory-info-dumper;1",
                                          "nsIMemoryInfoDumper");
         md.dumpMemoryReportsToNamedFile(dumpfile, function () {
             info("TEST-INFO | " + testURL + " | MEMDUMP-END");
         }, null, /* anonymize = */ false);
     }
 
     // This is the old, deprecated function.
-    if (dumpDMD && typeof(DMDReportAndDump) != undefined) {
+    if (dumpDMD && typeof(DMDReportAndDump) != "undefined") {
         var basename = "dmd-" + testNumber + "-deprecated.txt";
         var dumpfile = MemoryStats.constructPathname(dumpOutputDirectory,
                                                      basename);
         info(testURL + " | DMD-DUMP-deprecated " + dumpfile);
         DMDReportAndDump(dumpfile);
     }
 
-    if (dumpDMD && typeof(DMDAnalyzeReports) != undefined) {
+    if (dumpDMD && typeof(DMDAnalyzeReports) != "undefined") {
         var basename = "dmd-" + testNumber + ".txt";
         var dumpfile = MemoryStats.constructPathname(dumpOutputDirectory,
                                                      basename);
         info(testURL + " | DMD-DUMP " + dumpfile);
         DMDAnalyzeReports(dumpfile);
     }
 };