Bug 1341452 - MediaResult::Description() also describes successes - r?jya draft
authorGerald Squelart <gsquelart@mozilla.com>
Tue, 21 Feb 2017 16:54:08 +1100
changeset 487654 fd50c65034ffa20dbfbbbfdbb399dd1940590f0d
parent 487653 c16d9e9b79a6509d3f373a73ff4957f1b2d374f5
child 487657 b91eceffecc1269325bdb76e53071169aa55e7f8
push id46285
push usergsquelart@mozilla.com
push dateTue, 21 Feb 2017 22:32:14 +0000
reviewersjya
bugs1341452
milestone54.0a1
Bug 1341452 - MediaResult::Description() also describes successes - r?jya Also show whether the nsresult is a failure or success code. MozReview-Commit-ID: BJfSSrCEHEd
dom/media/MediaResult.h
--- a/dom/media/MediaResult.h
+++ b/dom/media/MediaResult.h
@@ -45,23 +45,21 @@ public:
 
   // Interoperations with nsresult.
   bool operator==(nsresult aResult) const { return aResult == mCode; }
   bool operator!=(nsresult aResult) const { return aResult != mCode; }
   operator nsresult () const { return mCode; }
 
   nsCString Description() const
   {
-    if (NS_SUCCEEDED(mCode)) {
-      return nsCString();
-    }
     nsCString name;
     GetErrorName(mCode, static_cast<nsACString&>(name));
-    return nsPrintfCString("%s (0x%08" PRIx32 ")%s%s",
+    return nsPrintfCString("%s (%s 0x%08" PRIx32 ")%s%s",
                            name.get(),
+                           NS_FAILED(mCode) ? "Failure " : "Success ",
                            static_cast<uint32_t>(mCode),
                            mMessage.IsEmpty() ? "" : " - ",
                            mMessage.get());
   }
 
 private:
   nsresult mCode;
   nsCString mMessage;