autoland: remove pycharm testrunner PYTHONPATH hack (bug 1337517) r?smacleod draft
authorMāris Fogels <mars@mozilla.com>
Tue, 21 Feb 2017 15:54:26 -0500
changeset 229 812e64dc7d145ec47c578f01bf235578cbfb098b
parent 228 9b59c9562abe8b3461a936eaf155098625e743a5
push id116
push usermfogels@mozilla.com
push dateThu, 23 Feb 2017 15:58:42 +0000
reviewerssmacleod
bugs1337517
autoland: remove pycharm testrunner PYTHONPATH hack (bug 1337517) r?smacleod Removed the pycharm testrunner PYTHONPATH hack in our test suite. The tests now pass without it. MozReview-Commit-ID: IfmO5VjhiCI
autoland/webapi/tests/test_dockerflow_container_api.py
autoland/webapi/tests/test_repo_check.py
--- a/autoland/webapi/tests/test_dockerflow_container_api.py
+++ b/autoland/webapi/tests/test_dockerflow_container_api.py
@@ -5,22 +5,17 @@
 Tests to ensure we honour the Dockerflow container API specification.
 
 See https://github.com/mozilla-services/Dockerflow for details.
 """
 import json
 
 import pytest
 
-# FIXME: need to get pycharm test runner to add /app to the container
-# PYTHONPATH
-import sys
-sys.path.insert(0, '/app')
-
-from autolandweb.server import make_app  # noqa
+from autolandweb.server import make_app
 
 
 @pytest.fixture
 def app():
     """Returns the tornado.Application instance we'll be testing against.
 
     Required for pytest-tornado to function.
     """
--- a/autoland/webapi/tests/test_repo_check.py
+++ b/autoland/webapi/tests/test_repo_check.py
@@ -5,17 +5,18 @@
 Test repository handling logic.
 """
 
 from autolandweb.server import make_app
 from autolandweb.testing import MountebankClient
 
 import pytest
 
-# FIXME: need to get pycharm test runner to add /app to the container PYTHONPATH # noqa
+# FIXME: need to get pycharm test runner to add /app to the container
+# PYTHONPATH
 import sys
 sys.path.insert(0, '/app')
 
 
 class FakeReviewBoard:
     def __init__(self, mountebank_client):
         self.mountebank = mountebank_client