Bug 1340733 - Fix attributes getter in win/ProxyAccessible. r=yzen draft
authorEitan Isaacson <eitan@monotonous.org>
Thu, 16 Feb 2017 15:32:19 -0800
changeset 487068 e3c9129703a84a697f7937dad0273d1972b627ad
parent 485594 debb1b927f6a524a183a45d14367dea51f8ae7b8
child 546372 1bf7fe40444aa72a7f5965fe6bd78c887d270775
push id46120
push userbmo:eitan@monotonous.org
push dateMon, 20 Feb 2017 15:25:19 +0000
reviewersyzen
bugs1340733
milestone54.0a1
Bug 1340733 - Fix attributes getter in win/ProxyAccessible. r=yzen MozReview-Commit-ID: 7s3UrJlcsEQ
accessible/ipc/win/ProxyAccessible.cpp
accessible/tests/browser/e10s/browser.ini
--- a/accessible/ipc/win/ProxyAccessible.cpp
+++ b/accessible/ipc/win/ProxyAccessible.cpp
@@ -334,16 +334,17 @@ ConvertBSTRAttributesToArray(const nsASt
         tokens[eName].Truncate();
         tokens[eValue].Truncate();
         ++itr;
         continue;
       default:
         break;
     }
     tokens[state] += *itr;
+    ++itr;
   }
   return true;
 }
 
 void
 ProxyAccessible::Attributes(nsTArray<Attribute>* aAttrs) const
 {
   aAttrs->Clear();
--- a/accessible/tests/browser/e10s/browser.ini
+++ b/accessible/tests/browser/e10s/browser.ini
@@ -10,67 +10,42 @@ support-files =
   doc_treeupdate_whitespace.html
   !/accessible/tests/browser/shared-head.js
   !/accessible/tests/mochitest/*.js
   !/accessible/tests/mochitest/letters.gif
   !/accessible/tests/mochitest/moz.png
 
 # Caching tests
 [browser_caching_attributes.js]
-skip-if = e10s && os == 'win' # Bug 1288839
 [browser_caching_description.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 [browser_caching_name.js]
 skip-if = e10s && os == 'win' && debug # Bug 1338034, leaks
 [browser_caching_relations.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 [browser_caching_states.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 [browser_caching_value.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 
 # Events tests
 [browser_events_caretmove.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 [browser_events_hide.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 [browser_events_show.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 [browser_events_statechange.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 [browser_events_textchange.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 
 # Tree update tests
 [browser_treeupdate_ariadialog.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 [browser_treeupdate_ariaowns.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 [browser_treeupdate_canvas.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 [browser_treeupdate_cssoverflow.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 [browser_treeupdate_doc.js]
 skip-if = e10s && os == 'win' # Bug 1288839
 [browser_treeupdate_gencontent.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 [browser_treeupdate_hidden.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 [browser_treeupdate_imagemap.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 [browser_treeupdate_list.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 [browser_treeupdate_list_editabledoc.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 [browser_treeupdate_listener.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 [browser_treeupdate_optgroup.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 [browser_treeupdate_removal.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 [browser_treeupdate_table.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 [browser_treeupdate_textleaf.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 [browser_treeupdate_visibility.js]
-skip-if = e10s && os == 'win' && os_version == '5.1'
 [browser_treeupdate_whitespace.js]
 skip-if = true # Failing due to incorrect index of test container children on document load.