Bug 1340734: Move the TLS detection logic to TestNrSocket::create, to keep up with changes from bug 1336507. r?drno draft
authorByron Campen [:bwc] <docfaraday@gmail.com>
Fri, 17 Feb 2017 17:31:55 -0600
changeset 486468 9aae72220edf2ea80b18dac5f26eb4b5a1d097c6
parent 486425 f302def88fe5040923ffc2295b7c804b693e7b79
child 546250 c97c630ca04789824d14bedfef4702e988ac9bb5
push id45988
push userbcampen@mozilla.com
push dateFri, 17 Feb 2017 23:32:41 +0000
reviewersdrno
bugs1340734, 1336507
milestone54.0a1
Bug 1340734: Move the TLS detection logic to TestNrSocket::create, to keep up with changes from bug 1336507. r?drno MozReview-Commit-ID: A0wYXBmvhyh
media/mtransport/test_nr_socket.cpp
--- a/media/mtransport/test_nr_socket.cpp
+++ b/media/mtransport/test_nr_socket.cpp
@@ -244,16 +244,20 @@ RefPtr<NrSocketBase> TestNrSocket::creat
                                 __FUNCTION__, r);
     return nullptr;
   }
 
   return external_socket;
 }
 
 int TestNrSocket::create(nr_transport_addr *addr) {
+  if (addr->tls_host[0] != '\0') {
+    tls_ = true;
+  }
+
   return NrSocketBase::CreateSocket(addr, &internal_socket_);
 }
 
 int TestNrSocket::getaddr(nr_transport_addr *addrp) {
   return internal_socket_->getaddr(addrp);
 }
 
 void TestNrSocket::close() {
@@ -472,20 +476,16 @@ bool TestNrSocket::allow_ingress(const n
 
 int TestNrSocket::connect(nr_transport_addr *addr) {
 
   if (connect_invoked_ || !port_mappings_.empty()) {
     MOZ_CRASH("TestNrSocket::connect() called more than once!");
     return R_INTERNAL;
   }
 
-  if (addr->tls_host[0] != '\0') {
-    tls_ = true;
-  }
-
   if (!nat_->enabled_
       || addr->protocol==IPPROTO_UDP  // Horrible hack to allow default address
                                       // discovery to work. Only works because
                                       // we don't normally connect on UDP.
       || nat_->is_an_internal_tuple(*addr)) {
     // This will set connect_invoked_
     return internal_socket_->connect(addr);
   }