Bug 1340671 - [webext] Fix race in getDevToolsTargetForContext utility method. r?kmag draft
authorLuca Greco <lgreco@mozilla.com>
Fri, 17 Feb 2017 21:50:49 +0100
changeset 486338 254141ffaa8a334059832f0b4ca80a0784e8b1bb
parent 485692 6cefe01ca7744d6ac3960c69eac833e2e65f7f8f
child 546224 23457ec28c976991a4e764129b0b3451ff65a5c0
push id45960
push userluca.greco@alcacoop.it
push dateFri, 17 Feb 2017 20:53:25 +0000
reviewerskmag
bugs1340671
milestone54.0a1
Bug 1340671 - [webext] Fix race in getDevToolsTargetForContext utility method. r?kmag MozReview-Commit-ID: 82r45FeljAV
browser/components/extensions/ext-devtools.js
--- a/browser/components/extensions/ext-devtools.js
+++ b/browser/components/extensions/ext-devtools.js
@@ -35,16 +35,17 @@ let initDevTools;
  *   A devtools extension proxy context.
  *
  * @returns {Promise<TabTarget>}
  *   The cloned devtools target associated to the context.
  */
 global.getDevToolsTargetForContext = (context) => {
   return Task.spawn(function* asyncGetTabTarget() {
     if (context.devToolsTarget) {
+      yield context.devToolsTarget.makeRemote();
       return context.devToolsTarget;
     }
 
     if (!context.devToolsToolbox || !context.devToolsToolbox.target) {
       throw new Error("Unable to get a TabTarget for a context not associated to any toolbox");
     }
 
     if (!context.devToolsToolbox.target.isLocalTab) {