Bug 1340093 - Use same digest/signing algorithm as a release build r=rail draft
authorJohan Lorenzo <jlorenzo@mozilla.com>
Thu, 16 Feb 2017 16:13:07 +0100
changeset 485355 4106aa7182fdd5080c2f1fa03b1a6d6bf7a5cd2f
parent 485098 a9ec72f82299250e6023988e238931bbca0ef7fa
child 545991 f8204da928f45887c275b5c77390f7503cdd84b1
push id45704
push userbmo:jlorenzo@mozilla.com
push dateThu, 16 Feb 2017 15:13:47 +0000
reviewersrail
bugs1340093
milestone54.0a1
Bug 1340093 - Use same digest/signing algorithm as a release build r=rail MozReview-Commit-ID: Ie0ZCFIRkQg
mobile/android/debug_sign_tool.py
testing/mozharness/mozharness/base/signing.py
--- a/mobile/android/debug_sign_tool.py
+++ b/mobile/android/debug_sign_tool.py
@@ -91,33 +91,33 @@ class DebugKeystore:
 
         args = [ self.keytool,
                  '-genkeypair',
                  '-keystore', self.keystore,
                  '-storepass', 'android',
                  '-alias', self.alias,
                  '-keypass', 'android',
                  '-dname', 'CN=Android Debug,O=Android,C=US',
-                 '-keyalg', 'RSA',
+                 '-keyalg', 'DSA',
                  '-validity', '365',
                ]
         if self.verbose:
             args.append('-v')
         self._check(args)
         if self.verbose:
             log.info('Created alias %s in keystore %s' %
                      (self.alias, self.keystore))
 
     def sign(self, apk):
         if not self.keystore_contains_alias():
             self.create_alias_in_keystore()
 
         args = [ self.jarsigner,
                  '-digestalg', 'SHA1',
-                 '-sigalg', 'MD5withRSA',
+                 '-sigalg', 'SHA1withDSA',
                  '-keystore', self.keystore,
                  '-storepass', 'android',
                  apk,
                  self.alias,
                ]
         if self.verbose:
             args.append('-verbose')
         self._check(args)
--- a/testing/mozharness/mozharness/base/signing.py
+++ b/testing/mozharness/mozharness/base/signing.py
@@ -112,16 +112,18 @@ class AndroidSigningMixin(object):
         # This needs to run silently, so no run_command() or
         # get_output_from_command() (though I could add a
         # suppress_command_echo=True or something?)
         self.log("(signing %s)" % apk, level=log_level)
         try:
             p = subprocess.Popen([jarsigner, "-keystore", keystore,
                                  "-storepass", storepass,
                                  "-keypass", keypass,
+                                 "-digestalg", "SHA1",
+                                 "-sigalg", "SHA1withDSA",
                                  apk, key_alias],
                                  stdout=subprocess.PIPE,
                                  stderr=subprocess.STDOUT)
         except OSError:
             self.exception("Error while signing %s (missing %s?):" % (apk, jarsigner))
             return -2
         except ValueError:
             self.exception("Popen called with invalid arguments during signing?")