Bug 1328421 - Replace MessageId with ID in the IPDL parser. r=billm draft
authorAndrew McCreight <continuation@gmail.com>
Tue, 14 Feb 2017 09:53:25 -0800
changeset 483664 87fb62d6c2d2047cb492d9f6d50eff993f251263
parent 483658 3e1cfaee75636fb7c230c5f221c9931cc4c50491
child 545687 f1d7880e148cdbaa51280a2786daaa2dd9056d85
push id45366
push userbmo:continuation@gmail.com
push dateTue, 14 Feb 2017 17:57:03 +0000
reviewersbillm
bugs1328421
milestone54.0a1
Bug 1328421 - Replace MessageId with ID in the IPDL parser. r=billm MozReview-Commit-ID: YHfxmB1McY
ipc/ipdl/ipdl/parser.py
--- a/ipc/ipdl/ipdl/parser.py
+++ b/ipc/ipdl/ipdl/parser.py
@@ -106,18 +106,16 @@ def locFromTok(p, num):
 
 reserved = set((
         'async',
         'both',
         'child',
         'class',
         'compress',
         'compressall',
-        '__delete__',
-        'delete',                       # reserve 'delete' to prevent its use
         'from',
         'include',
         'intr',
         'manager',
         'manages',
         'namespace',
         'nested',
         'nullable',
@@ -435,36 +433,27 @@ def p_MessageDecl(p):
 
     if Parser.current.direction is None:
         _error(msg.loc, 'missing message direction')
     msg.direction = Parser.current.direction
 
     p[0] = msg
 
 def p_MessageBody(p):
-    """MessageBody : MessageId MessageInParams MessageOutParams OptionalMessageModifiers"""
+    """MessageBody : ID MessageInParams MessageOutParams OptionalMessageModifiers"""
     # FIXME/cjones: need better loc info: use one of the quals
-    loc, name = p[1]
-    msg = MessageDecl(loc)
+    name = p[1]
+    msg = MessageDecl(locFromTok(p, 1))
     msg.name = name
     msg.addInParams(p[2])
     msg.addOutParams(p[3])
     msg.addModifiers(p[4])
 
     p[0] = msg
 
-def p_MessageId(p):
-    """MessageId : ID
-                 | __DELETE__
-                 | DELETE"""
-    loc = locFromTok(p, 1)
-    if 'delete' == p[1]:
-        _error(loc, "`delete' is a reserved identifier")
-    p[0] = [ loc, p[1] ]
-
 def p_MessageInParams(p):
     """MessageInParams : '(' ParamList ')'"""
     p[0] = p[2]
 
 def p_MessageOutParams(p):
     """MessageOutParams : RETURNS '(' ParamList ')'
                         | """
     if 1 == len(p):