Bug 1339023 - Make Telemetry in-tree docs index page point to the updated Histogram docs. r=gfritzsche draft
authorAlessio Placitelli <alessio.placitelli@gmail.com>
Mon, 13 Feb 2017 12:06:41 +0100
changeset 482771 1b37e667ded52be7068cc793ef292f9228ab10e4
parent 482503 00d16f03506b7f9f754b01a0a458c05445ac6dba
child 545503 09a661a25dcec6565df340628ddfaeb3c77f20d1
push id45160
push useralessio.placitelli@gmail.com
push dateMon, 13 Feb 2017 12:41:34 +0000
reviewersgfritzsche
bugs1339023
milestone54.0a1
Bug 1339023 - Make Telemetry in-tree docs index page point to the updated Histogram docs. r=gfritzsche MozReview-Commit-ID: HIcv5AJIPhM
toolkit/components/telemetry/docs/collection/histograms.rst
toolkit/components/telemetry/docs/data/main-ping.rst
toolkit/components/telemetry/docs/index.rst
--- a/toolkit/components/telemetry/docs/collection/histograms.rst
+++ b/toolkit/components/telemetry/docs/collection/histograms.rst
@@ -21,16 +21,18 @@ They are collected through a common API 
     Before adding a new histogram,  you should consider using other collection mechanisms. For example, if the need is to track a single scalar value (e.g. number, boolean or string), you should use :doc:`scalars`.
 
 The histogram below is taken from Firefox's ``about:telemetry`` page. It shows a histogram used for tracking plugin shutdown times and the data collected over a single Firefox session. The timing data is grouped into buckets where the height of the blue bars represents the number of items in each bucket. The tallest bar, for example, indicates that there were 63 plugin shutdowns lasting between 129ms and 204ms.
 
 .. image:: sampleHistogram.png
 
 The histograms on the ``about:telemetry`` page only show the non-empty buckets in a histogram except for the bucket to the left of the first non-empty bucket and the bucket to the right of the last non-empty bucket.
 
+.. _choosing-histogram-type:
+
 Choosing a Histogram Type
 =========================
 
 The first step to adding a new histogram is to choose the histogram type that best represents the data being measured. The sample histogram used above is an "exponential" histogram.
 
 .. note::
 
     Ony ``flag`` and ``count`` histograms have default values. All other histograms start out empty and are only submitted if a value is recorded.
--- a/toolkit/components/telemetry/docs/data/main-ping.rst
+++ b/toolkit/components/telemetry/docs/data/main-ping.rst
@@ -233,17 +233,17 @@ This measure might be useful to give a t
 Note that in ``main`` pings, this measure is reset on subsession splits, while in ``saved-session`` pings it covers the whole browser session.
 
 pingsOverdue
 ~~~~~~~~~~~~
 Integer count of pending pings that are overdue.
 
 histograms
 ----------
-This section contains the histograms that are valid for the current platform. ``Flag`` and ``count`` histograms are always created and submitted, with their default value being respectively ``false`` and ``0``. Other histogram types (`see here <https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Adding_a_new_Telemetry_probe#Choosing_a_Histogram_Type>`_) are not created nor submitted if no data was added to them. The type and format of the reported histograms is described by the ``Histograms.json`` file. Its most recent version is available `here <https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/Histograms.json>`_. The ``info.revision`` field indicates the revision of the file that describes the reported histograms.
+This section contains the histograms that are valid for the current platform. ``Flag`` and ``count`` histograms are always created and submitted, with their default value being respectively ``false`` and ``0``. Other histogram types (see :ref:`choosing-histogram-type`) are not created nor submitted if no data was added to them. The type and format of the reported histograms is described by the ``Histograms.json`` file. Its most recent version is available `here <https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/Histograms.json>`_. The ``info.revision`` field indicates the revision of the file that describes the reported histograms.
 
 keyedHistograms
 ---------------
 This section contains the keyed histograms available for the current platform.
 
 As of Firefox 48, this section does not contain empty keyed histograms anymore.
 
 threadHangStats
--- a/toolkit/components/telemetry/docs/index.rst
+++ b/toolkit/components/telemetry/docs/index.rst
@@ -3,17 +3,17 @@
 =========
 Telemetry
 =========
 
 Telemetry is a feature that allows data collection. This is being used to collect performance metrics and other information about how Firefox performs in the wild.
 
 Client-side, this consists of:
 
-* data collection in `Histograms <https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Adding_a_new_Telemetry_probe>`_, :doc:`collection/scalars` and other data structures
+* :doc:`data collection <collection/index>`, e.g. in histograms and scalars
 * assembling :doc:`concepts/pings` with the general information and the data payload
 * sending them to the server and local ping retention
 
 *Note:* the `data collection policy <https://wiki.mozilla.org/Firefox/Data_Collection>`_ documents the process and requirements that are applied here.
 
 .. toctree::
    :maxdepth: 5
    :titlesonly: