Bug 1335337 - Restrict special <button type="menu"> theming to XUL <button> elements. r?enndeakin draft
authorMarkus Stange <mstange@themasta.com>
Fri, 10 Feb 2017 13:20:19 -0500
changeset 481896 56efe694cf8ab2d2a8a109277e5b77e1a71c2529
parent 481895 324536d29587dd805b35645aa138666844d59123
child 545312 92c04c2a7c8da768de91ba2b73632ad7f6dfdaf7
push id44946
push userbmo:mstange@themasta.com
push dateFri, 10 Feb 2017 18:21:05 +0000
reviewersenndeakin
bugs1335337
milestone54.0a1
Bug 1335337 - Restrict special <button type="menu"> theming to XUL <button> elements. r?enndeakin MozReview-Commit-ID: 8qqsQMroTS
widget/nsNativeTheme.cpp
--- a/widget/nsNativeTheme.cpp
+++ b/widget/nsNativeTheme.cpp
@@ -219,17 +219,18 @@ nsNativeTheme::GetCheckedOrSelected(nsIF
 
 bool
 nsNativeTheme::IsButtonTypeMenu(nsIFrame* aFrame)
 {
   if (!aFrame)
     return false;
 
   nsIContent* content = aFrame->GetContent();
-  return content->AttrValueIs(kNameSpaceID_None, nsGkAtoms::type,
+  return content->IsXULElement(nsGkAtoms::button) &&
+         content->AttrValueIs(kNameSpaceID_None, nsGkAtoms::type,
                               NS_LITERAL_STRING("menu"), eCaseMatters);
 }
 
 bool
 nsNativeTheme::IsPressedButton(nsIFrame* aFrame)
 {
   EventStates eventState = GetContentState(aFrame, NS_THEME_TOOLBARBUTTON);
   if (IsDisabled(aFrame, eventState))