Bug
Bug 1338517 - fix false positive for static analysis in mergeStacksIntoProfile. r?mstange
MozReview-Commit-ID: AOYksJVNkwi
--- a/tools/profiler/core/Sampler.cpp
+++ b/tools/profiler/core/Sampler.cpp
@@ -743,17 +743,17 @@ mergeStacksIntoProfile(ThreadInfo& aInfo
}
uint32_t jsCount = 0;
JS::ProfilingFrameIterator::Frame jsFrames[1000];
// Only walk jit stack if profiling frame iterator is turned on.
if (pseudoStack->mContext && JS::IsProfilingEnabledForContext(pseudoStack->mContext)) {
AutoWalkJSStack autoWalkJSStack;
const uint32_t maxFrames = mozilla::ArrayLength(jsFrames);
- if (aSample && autoWalkJSStack.walkAllowed) {
+ if (autoWalkJSStack.walkAllowed) {
JS::ProfilingFrameIterator::RegisterState registerState;
registerState.pc = aSample->pc;
registerState.sp = aSample->sp;
registerState.lr = aSample->lr;
JS::ProfilingFrameIterator jsIter(pseudoStack->mContext,
registerState,
startBufferGen);