Bug 1338461 - Pass eRestyle_StyleAttribute through to Servo_NoteExplicitHints. r=bholley draft
authorCameron McCormack <cam@mcc.id.au>
Mon, 20 Mar 2017 14:42:31 +0800
changeset 501410 638fe3e1c9ecf47dcd9b175ae03344450417c7da
parent 501295 1b9293be51637f841275541d8991314ca56561a5
child 549872 e0a114f5099aeff4fac87115e03985853330f868
push id49972
push userbmo:cam@mcc.id.au
push dateMon, 20 Mar 2017 07:46:19 +0000
reviewersbholley
bugs1338461
milestone55.0a1
Bug 1338461 - Pass eRestyle_StyleAttribute through to Servo_NoteExplicitHints. r=bholley MozReview-Commit-ID: C7HIOTs1SSY
dom/plugins/test/reftest/reftest-stylo.list
layout/base/ServoRestyleManager.cpp
--- a/dom/plugins/test/reftest/reftest-stylo.list
+++ b/dom/plugins/test/reftest/reftest-stylo.list
@@ -11,17 +11,17 @@ fails == plugin-sanity.html plugin-sanit
 == border-padding-3.html border-padding-3.html
 # The following two "pluginproblemui-direction" tests are unreliable on all platforms. They should be re-written or replaced.
 random-if(cocoaWidget||d2d||/^Windows\x20NT\x205\.1/.test(http.oscpu)) fails-if(!haveTestPlugin&&!Android) skip-if(stylo) == pluginproblemui-direction-1.html pluginproblemui-direction-1.html
 random-if(cocoaWidget) fails-if(!haveTestPlugin&&!Android) skip-if(stylo) == pluginproblemui-direction-2.html pluginproblemui-direction-2.html
 == plugin-canvas-alpha-zindex.html plugin-canvas-alpha-zindex.html
 fails == plugin-transform-alpha-zindex.html plugin-transform-alpha-zindex.html
 == plugin-busy-alpha-zindex.html plugin-busy-alpha-zindex.html
 == plugin-background.html plugin-background.html
-== plugin-background-1-step.html plugin-background-1-step.html
-== plugin-background-2-step.html plugin-background-2-step.html
-== plugin-background-5-step.html plugin-background-5-step.html
-== plugin-background-10-step.html plugin-background-10-step.html
+fails == plugin-background-1-step.html plugin-background-1-step.html # bug 1348723
+fails == plugin-background-2-step.html plugin-background-2-step.html # bug 1348723
+fails == plugin-background-5-step.html plugin-background-5-step.html # bug 1348723
+fails == plugin-background-10-step.html plugin-background-10-step.html # bug 1348723
 == plugin-transform-1.html plugin-transform-1.html
 fails == plugin-transform-2.html plugin-transform-2.html
 fails == shrink-1.html shrink-1.html
 == update-1.html update-1.html
 skip-if(!haveTestPlugin) == windowless-layers.html windowless-layers.html
--- a/layout/base/ServoRestyleManager.cpp
+++ b/layout/base/ServoRestyleManager.cpp
@@ -50,23 +50,16 @@ ServoRestyleManager::PostRestyleEvent(El
   // Processing change hints sometimes causes new change hints to be generated,
   // and very occasionally, additional restyle hints. We collect the change
   // hints manually to avoid re-traversing the DOM to find them.
   if (mReentrantChanges && !aRestyleHint) {
     mReentrantChanges->AppendElement(ReentrantChange { aElement, aMinChangeHint });
     return;
   }
 
-  // XXX This is a temporary hack to make style attribute change works.
-  //     In the future, we should be able to use this hint directly.
-  if (aRestyleHint & eRestyle_StyleAttribute) {
-    aRestyleHint &= ~eRestyle_StyleAttribute;
-    aRestyleHint |= eRestyle_Self | eRestyle_Subtree;
-  }
-
   if (aRestyleHint || aMinChangeHint) {
     Servo_NoteExplicitHints(aElement, aRestyleHint, aMinChangeHint);
   }
 
   PostRestyleEventInternal(false);
 }
 
 /* static */ void