Bug 1338086 - Remove useless else blocks in order to reduce complexity in toolkit/components/url-classifier/ r?francois draft
authorSylvestre Ledru <sledru@mozilla.com>
Thu, 09 Feb 2017 10:57:22 +0100
changeset 484409 12841f531dc3d313f241a5a150e63d0efeb5779c
parent 484408 a98c23f0935c6734e4db2df80aa9a42c46961a8d
child 484410 dcb1fd34816adaa606f6dcafc504c51498b5c769
push id45470
push userbmo:sledru@mozilla.com
push dateWed, 15 Feb 2017 08:57:47 +0000
reviewersfrancois
bugs1338086
milestone54.0a1
Bug 1338086 - Remove useless else blocks in order to reduce complexity in toolkit/components/url-classifier/ r?francois MozReview-Commit-ID: GTb9ME8pfVq
toolkit/components/url-classifier/HashStore.cpp
--- a/toolkit/components/url-classifier/HashStore.cpp
+++ b/toolkit/components/url-classifier/HashStore.cpp
@@ -298,19 +298,18 @@ HashStore::Open()
 
   nsCOMPtr<nsIInputStream> origStream;
   rv = NS_NewLocalFileInputStream(getter_AddRefs(origStream), storeFile,
                                   PR_RDONLY | nsIFile::OS_READAHEAD);
 
   if (rv == NS_ERROR_FILE_NOT_FOUND) {
     UpdateHeader();
     return NS_OK;
-  } else {
-    SUCCESS_OR_RESET(rv);
   }
+  SUCCESS_OR_RESET(rv);
 
   int64_t fileSize;
   rv = storeFile->GetFileSize(&fileSize);
   NS_ENSURE_SUCCESS(rv, rv);
 
   if (fileSize < 0 || fileSize > UINT32_MAX) {
     return NS_ERROR_FAILURE;
   }