Bug 1338086 - Remove useless else blocks in order to reduce complexity in dom/ipc r?baku draft
authorSylvestre Ledru <sledru@mozilla.com>
Thu, 09 Feb 2017 10:31:03 +0100
changeset 484399 6c4a0c614a3e06cfa0724a75cd2988557fff3c22
parent 484398 265ee704ac9f4ef9a202c2cf0942b7ce3a466378
child 484400 708de26ac7fd43ae391290fb607cc1fabc35b9dd
push id45470
push userbmo:sledru@mozilla.com
push dateWed, 15 Feb 2017 08:57:47 +0000
reviewersbaku
bugs1338086
milestone54.0a1
Bug 1338086 - Remove useless else blocks in order to reduce complexity in dom/ipc r?baku MozReview-Commit-ID: Fyx3eryjsgQ
dom/ipc/ContentChild.cpp
--- a/dom/ipc/ContentChild.cpp
+++ b/dom/ipc/ContentChild.cpp
@@ -2615,17 +2615,18 @@ ContentChild::RecvDomainSetChanged(const
     }
     nsIScriptSecurityManager* ssm = nsContentUtils::GetSecurityManager();
     MOZ_ASSERT(ssm);
     ssm->ActivateDomainPolicyInternal(getter_AddRefs(mPolicy));
     if (!mPolicy) {
       return IPC_FAIL_NO_REASON(this);
     }
     return IPC_OK();
-  } else if (!mPolicy) {
+  }
+  if (!mPolicy) {
     MOZ_ASSERT_UNREACHABLE("If the domain policy is not active yet,"
                            " the first message should be ACTIVATE_POLICY");
     return IPC_FAIL_NO_REASON(this);
   }
 
   NS_ENSURE_TRUE(mPolicy, IPC_FAIL_NO_REASON(this));
 
   if (aChangeType == DEACTIVATE_POLICY) {
@@ -2771,19 +2772,17 @@ ContentChild::RecvShutdown()
 
 PBrowserOrId
 ContentChild::GetBrowserOrId(TabChild* aTabChild)
 {
   if (!aTabChild ||
     this == aTabChild->Manager()) {
     return PBrowserOrId(aTabChild);
   }
-  else {
-    return PBrowserOrId(aTabChild->GetTabId());
-  }
+  return PBrowserOrId(aTabChild->GetTabId());
 }
 
 mozilla::ipc::IPCResult
 ContentChild::RecvUpdateWindow(const uintptr_t& aChildId)
 {
 #if defined(XP_WIN)
   NS_ASSERTION(aChildId, "Expected child hwnd value for remote plugin instance.");
   mozilla::plugins::PluginInstanceParent* parentInstance =