Bug 1338086 - Remove useless else blocks in order to reduce complexity in dom/canvas r?baku draft
authorSylvestre Ledru <sledru@mozilla.com>
Thu, 09 Feb 2017 10:29:26 +0100
changeset 484400 708de26ac7fd43ae391290fb607cc1fabc35b9dd
parent 484399 6c4a0c614a3e06cfa0724a75cd2988557fff3c22
child 484401 aba4a114f85df1e32230fbd0b057e7d7255eb417
push id45470
push userbmo:sledru@mozilla.com
push dateWed, 15 Feb 2017 08:57:47 +0000
reviewersbaku
bugs1338086
milestone54.0a1
Bug 1338086 - Remove useless else blocks in order to reduce complexity in dom/canvas r?baku MozReview-Commit-ID: EWXDsio2aBh
dom/canvas/ImageUtils.cpp
--- a/dom/canvas/ImageUtils.cpp
+++ b/dom/canvas/ImageUtils.cpp
@@ -48,23 +48,28 @@ GetImageBitmapFormatFromSurfaceFromat(Su
   }
 }
 
 static ImageBitmapFormat
 GetImageBitmapFormatFromPlanarYCbCrData(layers::PlanarYCbCrData const *aData)
 {
   MOZ_ASSERT(aData);
 
-  if (aData->mYSkip == 0 && aData->mCbSkip == 0 && aData->mCrSkip == 0) { // Possibly three planes.
-    if (aData->mCbChannel >= aData->mYChannel + aData->mYSize.height * aData->mYStride &&
-        aData->mCrChannel >= aData->mCbChannel + aData->mCbCrSize.height * aData->mCbCrStride) { // Three planes.
+  if (aData->mYSkip == 0 && aData->mCbSkip == 0 &&
+      aData->mCrSkip == 0) { // Possibly three planes.
+    if (aData->mCbChannel >=
+          aData->mYChannel + aData->mYSize.height * aData->mYStride &&
+        aData->mCrChannel >=
+          aData->mCbChannel +
+            aData->mCbCrSize.height * aData->mCbCrStride) { // Three planes.
       if (aData->mYSize.height == aData->mCbCrSize.height) {
         if (aData->mYSize.width == aData->mCbCrSize.width) {
           return ImageBitmapFormat::YUV444P;
-        } else if (((aData->mYSize.width + 1) / 2) == aData->mCbCrSize.width) {
+        }
+        if (((aData->mYSize.width + 1) / 2) == aData->mCbCrSize.width) {
           return ImageBitmapFormat::YUV422P;
         }
       } else if (((aData->mYSize.height + 1) / 2) == aData->mCbCrSize.height) {
         if (((aData->mYSize.width + 1) / 2) == aData->mCbCrSize.width) {
           return ImageBitmapFormat::YUV420P;
         }
       }
     }
@@ -186,27 +191,25 @@ public:
   {
     return GetImageBitmapFormatFromPlanarYCbCrData(GetPlanarYCbCrData());
   }
 
   uint32_t GetBufferLength() const override
   {
     if (mImage->GetFormat() == ImageFormat::PLANAR_YCBCR) {
       return mImage->AsPlanarYCbCrImage()->GetDataSize();
-    } else {
-      return mImage->AsNVImage()->GetBufferSize();
     }
+    return mImage->AsNVImage()->GetBufferSize();
   }
 
-  UniquePtr<ImagePixelLayout>
-  MapDataInto(uint8_t* aBuffer,
-              uint32_t aOffset,
-              uint32_t aBufferLength,
-              ImageBitmapFormat aFormat,
-              ErrorResult& aRv) const override
+  UniquePtr<ImagePixelLayout> MapDataInto(uint8_t* aBuffer,
+                                          uint32_t aOffset,
+                                          uint32_t aBufferLength,
+                                          ImageBitmapFormat aFormat,
+                                          ErrorResult& aRv) const override
   {
     // Prepare source buffer and pixel layout.
     const PlanarYCbCrData* data = GetPlanarYCbCrData();
 
     UniquePtr<ImagePixelLayout> srcLayout =
       CreatePixelLayoutFromPlanarYCbCrData(data);
 
     // Do conversion.
@@ -222,19 +225,18 @@ public:
     return dstLayout;
   }
 
 private:
   const PlanarYCbCrData* GetPlanarYCbCrData() const
   {
     if (mImage->GetFormat() == ImageFormat::PLANAR_YCBCR) {
       return mImage->AsPlanarYCbCrImage()->GetData();
-    } else {
-      return mImage->AsNVImage()->GetData();
     }
+    return mImage->AsNVImage()->GetData();
   }
 };
 
 // TODO: optimize for other platforms.
 // For GONK: implement GrallocImageImpl, GrallocPlanarYCbCrImpl and GonkCameraImpl.
 // For Windows: implement D3D9RGB32TextureImpl and D3D11ShareHandleTextureImpl.
 // Others: SharedBGRImpl, MACIOSrufaceImpl, GLImageImpl, SurfaceTextureImpl
 //         EGLImageImpl and OverlayImegImpl.