Bug 1338086 - Remove useless else blocks in order to reduce complexity in dom/browser-element/ r?baku draft
authorSylvestre Ledru <sledru@mozilla.com>
Thu, 09 Feb 2017 13:29:40 +0100
changeset 484401 aba4a114f85df1e32230fbd0b057e7d7255eb417
parent 484400 708de26ac7fd43ae391290fb607cc1fabc35b9dd
child 484402 18bf4d2d14ec4f98dce1621dc390f142e98e9ffb
push id45470
push userbmo:sledru@mozilla.com
push dateWed, 15 Feb 2017 08:57:47 +0000
reviewersbaku
bugs1338086
milestone54.0a1
Bug 1338086 - Remove useless else blocks in order to reduce complexity in dom/browser-element/ r?baku MozReview-Commit-ID: GOhpMjzT0m0
dom/browser-element/BrowserElementParent.cpp
--- a/dom/browser-element/BrowserElementParent.cpp
+++ b/dom/browser-element/BrowserElementParent.cpp
@@ -165,17 +165,18 @@ BrowserElementParent::DispatchOpenWindow
     DispatchCustomDOMEvent(aOpenerFrameElement,
                            NS_LITERAL_STRING("mozbrowseropenwindow"),
                            cx,
                            val, &status);
 
   if (dispatchSucceeded) {
     if (aPopupFrameElement->IsInUncomposedDoc()) {
       return BrowserElementParent::OPEN_WINDOW_ADDED;
-    } else if (status == nsEventStatus_eConsumeNoDefault) {
+    }
+    if (status == nsEventStatus_eConsumeNoDefault) {
       // If the frame was not added to a document, report to callers whether
       // preventDefault was called on or not
       return BrowserElementParent::OPEN_WINDOW_CANCELLED;
     }
   }
 
   return BrowserElementParent::OPEN_WINDOW_IGNORED;
 }