Bug 1337897 - RTL the padding between the close button and title in tab grid layouts. r?sebastian draft
authorTom Klein <twointofive@gmail.com>
Wed, 08 Feb 2017 16:50:22 -0600
changeset 480966 00575156db7c0b4dbdd1bdec78e3a571605f5c1f
parent 479455 12c02bf624c48903b155428f7c8a419ba7a333a6
child 545071 73ef30c5ce2a815c3557237a73ac692160bfd909
push id44674
push userbmo:twointofive@gmail.com
push dateThu, 09 Feb 2017 01:14:08 +0000
reviewerssebastian
bugs1337897
milestone54.0a1
Bug 1337897 - RTL the padding between the close button and title in tab grid layouts. r?sebastian There's apparently a bug which causes *both* paddingRight and paddingEnd to be applied (in my case on an API 23 emulator); the workaround, in this case, is to also specify paddingLeft and paddingStart (with values "0dp"). MozReview-Commit-ID: 98hm1GcSPxi
mobile/android/base/resources/layout/tabs_layout_item_view.xml
--- a/mobile/android/base/resources/layout/tabs_layout_item_view.xml
+++ b/mobile/android/base/resources/layout/tabs_layout_item_view.xml
@@ -27,16 +27,19 @@
                android:layout_weight="1.0"
                style="@style/TabLayoutItemTextAppearance"
                android:textSize="14sp"
                android:textColor="@color/tab_item_title"
                android:singleLine="true"
                android:duplicateParentState="true"
                gecko:fadeWidth="15dp"
                android:paddingRight="5dp"
+               android:paddingEnd="5dp"
+               android:paddingLeft="0dp"
+               android:paddingStart="0dp"
                android:drawablePadding="6dp"/>
 
         <!-- Use of baselineAlignBottom only supported from API 11+ - if this needs to work on lower API versions
              we'll need to override getBaseLine() and return image height, but we assume this won't happen -->
         <ImageView android:id="@+id/close"
                      style="@style/TabsItemClose"
                      android:layout_width="wrap_content"
                      android:layout_height="wrap_content"