Bug 1308610 part 1: Remove use-counter mochitest's flaky chunk about testing counters in SVG "list-style-image" docs. r?froydnj
It's hard to predict the timing of SVG-as-an-image document teardown, for SVG
images used in CSS, so this piece of the test was flaky. And anyway, we have
other tests for use counters in SVG-as-an-image (see calls to
"check_use_counter_img"), which should exercise the codepath we care about here.
MozReview-Commit-ID: DbYWDYUOc1c
--- a/dom/base/test/browser.ini
+++ b/dom/base/test/browser.ini
@@ -2,17 +2,16 @@
support-files =
empty.html
file_bug1011748_redirect.sjs
file_bug1011748_OK.sjs
file_messagemanager_unload.html
file_use_counter_outer.html
file_use_counter_svg_getElementById.svg
file_use_counter_svg_currentScale.svg
- file_use_counter_svg_list_style_image.html
file_use_counter_svg_fill_pattern_definition.svg
file_use_counter_svg_fill_pattern.svg
file_use_counter_svg_fill_pattern_internal.svg
file_use_counter_svg_fill_pattern_data.svg
[browser_bug593387.js]
[browser_bug902350.js]
tags = mcb
--- a/dom/base/test/browser_use_counters.js
+++ b/dom/base/test/browser_use_counters.js
@@ -66,22 +66,16 @@ add_task(function* () {
// Check that use counters are incremented by directly loading SVGs
// that reference patterns defined in the same file or in data: URLs.
yield check_use_counter_direct("file_use_counter_svg_fill_pattern_internal.svg",
"PROPERTY_FILLOPACITY");
// data: URLs don't correctly propagate to their referring document yet.
//yield check_use_counter_direct("file_use_counter_svg_fill_pattern_data.svg",
// "PROPERTY_FILL_OPACITY");
-
- // Check that use counters are incremented by SVGs loaded as CSS images in
- // pages loaded in iframes. Again, SVG images in CSS aren't permitted to
- // execute script, so we need to use properties here.
- yield check_use_counter_iframe("file_use_counter_svg_list_style_image.html",
- "PROPERTY_FILL");
});
add_task(function* () {
let Telemetry = Cc["@mozilla.org/base/telemetry;1"].getService(Ci.nsITelemetry);
Telemetry.canRecordExtended = gOldParentCanRecord;
yield ContentTask.spawn(gBrowser.selectedBrowser, { oldCanRecord: gOldContentCanRecord }, function* (arg) {
Cu.import("resource://gre/modules/PromiseUtils.jsm");
deleted file mode 100644
--- a/dom/base/test/file_use_counter_svg_list_style_image.html
+++ /dev/null
@@ -1,22 +0,0 @@
-<!DOCTYPE HTML>
-<html>
-<!--
-https://bugzilla.mozilla.org/show_bug.cgi?id=968923
--->
-<head>
- <meta charset="utf-8">
- <title>Test for Bug 968923</title>
- <style>
-/* Use a query string to work around imagelib caching.
- Otherwise, we won't get use counters for this file. */
-ul { list-style-image: url('file_use_counter_svg_currentScale.svg?asliststyleimage=1') }
- </style>
-</head>
-<body>
-<a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=968923">Mozilla Bug 968923</a>
-<ul>
- <li>Some text</li>
- <li>Some other text</li>
-</ul>
-</body>
-</html>