Bug 1325523 - Persist tracked IDs on finalization, and don't persist IDs in Sync tests. r?markh
MozReview-Commit-ID: CpQP2aM1DO
--- a/services/sync/modules/engines.js
+++ b/services/sync/modules/engines.js
@@ -728,17 +728,18 @@ Engine.prototype = {
* must have a `validate(engine)` method that returns a promise to an object
* with a getSummary method). Otherwise return null.
*/
getValidator() {
return null;
},
finalize() {
- // Ensure the tracker finishes persisting changed IDs to disk.
+ // Persist all pending tracked changes to disk.
+ this._tracker._saveChangedIDs();
Async.promiseSpinningly(this._tracker._storage.finalize());
},
};
this.SyncEngine = function SyncEngine(name, service) {
Engine.call(this, name || "SyncEngine", service);
this.loadToFetch();
--- a/services/sync/tests/unit/test_engine.js
+++ b/services/sync/tests/unit/test_engine.js
@@ -18,17 +18,18 @@ SteamStore.prototype = {
this.wasWiped = true;
}
};
function SteamTracker(name, engine) {
Tracker.call(this, name || "Steam", engine);
}
SteamTracker.prototype = {
- __proto__: Tracker.prototype
+ __proto__: Tracker.prototype,
+ persistChangedIDs: false,
};
function SteamEngine(name, service) {
Engine.call(this, name, service);
this.wasReset = false;
this.wasSynced = false;
}
SteamEngine.prototype = {
--- a/services/sync/tests/unit/test_telemetry.js
+++ b/services/sync/tests/unit/test_telemetry.js
@@ -28,17 +28,18 @@ SteamStore.prototype = {
__proto__: Store.prototype,
};
function SteamTracker(name, engine) {
Tracker.call(this, name || "Steam", engine);
}
SteamTracker.prototype = {
- __proto__: Tracker.prototype
+ __proto__: Tracker.prototype,
+ persistChangedIDs: false,
};
function SteamEngine(service) {
Engine.call(this, "steam", service);
}
SteamEngine.prototype = {
__proto__: Engine.prototype,