Bug 1336865 - Add telemetry to measure time spent on constructing variable-length prefix set. r?francois draft
authordimi <dlee@mozilla.com>
Tue, 07 Feb 2017 16:14:58 +0800
changeset 479794 4ac6bc4a9ef54addc04adb480d896f8ae3b83198
parent 479651 af8a2573d0f1e9cc6f2ba0ab67d7a702a197f177
child 544780 f99bc24cc146e5c77de84acf3a47c82ce9f42b04
push id44358
push userdlee@mozilla.com
push dateTue, 07 Feb 2017 08:15:31 +0000
reviewersfrancois
bugs1336865
milestone54.0a1
Bug 1336865 - Add telemetry to measure time spent on constructing variable-length prefix set. r?francois MozReview-Commit-ID: CNhfYdH1ryA
toolkit/components/telemetry/Histograms.json
toolkit/components/url-classifier/LookupCacheV4.cpp
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -4019,16 +4019,25 @@
     "alert_emails": ["safebrowsing-telemetry@mozilla.org"],
     "expires_in_version": "58",
     "kind": "exponential",
     "high": 1000,
     "n_buckets": 10,
     "bug_numbers": [1283007],
     "description": "Time spent fallocating Variable-Length PrefixSet (ms)"
   },
+  "URLCLASSIFIER_VLPS_CONSTRUCT_TIME": {
+    "alert_emails": ["safebrowsing-telemetry@mozilla.org"],
+    "expires_in_version": "60",
+    "kind": "exponential",
+    "high": 5000,
+    "n_buckets": 15,
+    "bug_numbers": [1336865],
+    "description": "Time spent constructing Variable-Length PrefixSet from file (ms)"
+  },
   "URLCLASSIFIER_VLPS_LOAD_CORRUPT": {
     "alert_emails": ["safebrowsing-telemetry@mozilla.org"],
     "expires_in_version": "58",
     "kind": "boolean",
     "bug_numbers": [1305581],
     "description": "Whether or not a variable-length prefix set loaded from disk is corrupted (true = file corrupted)."
   },
   "URLCLASSIFIER_LC_PREFIXES": {
--- a/toolkit/components/url-classifier/LookupCacheV4.cpp
+++ b/toolkit/components/url-classifier/LookupCacheV4.cpp
@@ -115,16 +115,18 @@ LookupCacheV4::IsHashEntryConfirmed(cons
 {
   // TODO : Bug 1311935 - Implement v4 caching
   *aConfirmed = true;
 }
 
 nsresult
 LookupCacheV4::Build(PrefixStringMap& aPrefixMap)
 {
+  Telemetry::AutoTimer<Telemetry::URLCLASSIFIER_VLPS_CONSTRUCT_TIME> timer;
+
   return mVLPrefixSet->SetPrefixes(aPrefixMap);
 }
 
 nsresult
 LookupCacheV4::GetPrefixes(PrefixStringMap& aPrefixMap)
 {
   return mVLPrefixSet->GetPrefixes(aPrefixMap);
 }