Bug 1337073 - Rename IPC_SYNC_LATENCY_MS to IPC_LINEAR_SYNC_LATENCY_MS and make it linear. r?billm,r?francois draft
authorChris Pearce <cpearce@mozilla.com>
Tue, 07 Feb 2017 12:00:08 +1300
changeset 479573 e288d3e79ef33bee016ffe40996e8c6bf1a518f3
parent 479141 20a8536b0bfac74389d3a57bd8dd957d98779ce1
child 544728 43a26cd3d1a84097f1171c28d549691891bd061d
push id44299
push userbmo:cpearce@mozilla.com
push dateMon, 06 Feb 2017 23:00:38 +0000
reviewersbillm, francois
bugs1337073
milestone54.0a1
Bug 1337073 - Rename IPC_SYNC_LATENCY_MS to IPC_LINEAR_SYNC_LATENCY_MS and make it linear. r?billm,r?francois This will make it easier to interpret, as we'll have consistent ranges in the histogram boxes. MozReview-Commit-ID: LN3FQO6qeGD
ipc/glue/MessageChannel.cpp
toolkit/components/telemetry/Histograms.json
--- a/ipc/glue/MessageChannel.cpp
+++ b/ipc/glue/MessageChannel.cpp
@@ -1275,17 +1275,17 @@ MessageChannel::Send(Message* aMsg, Mess
 
     *aReply = Move(*reply);
     if (aReply->size() >= kMinTelemetryMessageSize) {
         Telemetry::Accumulate(Telemetry::IPC_REPLY_SIZE,
                               nsDependentCString(msgName), aReply->size());
     }
 
     if (latencyMs >= kMinTelemetrySyncIPCLatencyMs) {
-      Telemetry::Accumulate(Telemetry::IPC_SYNC_LATENCY_MS,
+      Telemetry::Accumulate(Telemetry::IPC_LINEAR_SYNC_LATENCY_MS,
                             nsDependentCString(msgName), latencyMs);
     }
     return true;
 }
 
 bool
 MessageChannel::Call(Message* aMsg, Message* aReply)
 {
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -10303,23 +10303,23 @@
     "bug_numbers": [1264820],
     "expires_in_version": "55",
     "kind": "exponential",
     "high": 8000000,
     "n_buckets": 50,
     "keyed": true,
     "description": "Measures the size of IPC messages by message name"
   },
-  "IPC_SYNC_LATENCY_MS": {
+  "IPC_LINEAR_SYNC_LATENCY_MS": {
     "alert_emails": ["cpearce@mozilla.com"],
     "bug_numbers": [1333489],
     "expires_in_version": "60",
-    "kind": "exponential",
+    "kind": "linear",
     "high": 2000,
-    "n_buckets": 10,
+    "n_buckets": 20,
     "keyed": true,
     "description": "Measures the number of milliseconds we spend waiting for sync IPC messages to finish sending, keyed by message name. Note: only messages that wait for more than 500 microseconds are included in this probe."
   },
   "MESSAGE_MANAGER_MESSAGE_SIZE2": {
     "alert_emails": ["wmccloskey@mozilla.com","amccreight@mozilla.com"],
     "bug_numbers": [1260908],
     "expires_in_version": "55",
     "kind": "exponential",